Skip to content

fix(sherif): remove unnecessary option and ignore directory #6701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Jan 14, 2024

@TkDodo I saw your feature request in QuiiBz/sherif#41 and feature is added in v7.0.0 of sherif
Thanks to request feature to sherif. I am using this tool and this I needed this feature too.

To resolve your comment in #6686 I updated script for sherif. from now we don't have to use unnecessary option(-i react-scripts -i typescript) So cool👍

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2024 6:11pm

Copy link

nx-cloud bot commented Jan 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d7b08c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Jan 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d7b08c:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a127bf) 41.71% compared to head (0d7b08c) 41.71%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6701   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files         179      179           
  Lines        7007     7007           
  Branches     1416     1416           
=======================================
  Hits         2923     2923           
  Misses       3713     3713           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manudeli manudeli changed the title fix(sherif): ignore directory fix(sherif): remove unnecessary option and ignore directory Jan 14, 2024
@manudeli manudeli marked this pull request as ready for review January 14, 2024 18:17
@TkDodo TkDodo merged commit 4a93146 into TanStack:main Jan 14, 2024
@TkDodo
Copy link
Collaborator

TkDodo commented Jan 14, 2024

not sure how but this is failing on main:

https://cloud.nx.app/runs/oblIhu1Dfj

> query@ test:sherif /home/runner/work/query/query
> sherif --ignore-package ./integrations/*

error: unexpected argument './integrations/react-cra5' found

Usage: sherif [OPTIONS] [PATH]

Can you please investigate and fix it, or I need to revert. Thanks

@manudeli
Copy link
Collaborator Author

not sure how but this is failing on main:

https://cloud.nx.app/runs/oblIhu1Dfj

> query@ test:sherif /home/runner/work/query/query
> sherif --ignore-package ./integrations/*

error: unexpected argument './integrations/react-cra5' found

Usage: sherif [OPTIONS] [PATH]

Can you please investigate and fix it, or I need to revert. Thanks

@TkDodo Revert first please not to affect other branches working, I will investigate it soon

@manudeli
Copy link
Collaborator Author

@TkDodo, I started to investigate this issue in QuiiBz/sherif#51

@QuiiBz
Copy link

QuiiBz commented Jan 22, 2024

Hi, seems like your shell automatically interprets and expand *, so the resulting command is indeed incorrect. In that case, you have to wrap the argument in quotes: sherif --ignore-package "./integrations/*"

Note that this isn't related to Sherif directly, but I'll update the documentation to include these quotes.

Screenshot 2024-01-22 at 12 45 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants