-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(sherif): remove unnecessary option and ignore directory #6701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0d7b08c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d7b08c:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
=======================================
Coverage 41.71% 41.71%
=======================================
Files 179 179
Lines 7007 7007
Branches 1416 1416
=======================================
Hits 2923 2923
Misses 3713 3713
Partials 371 371 ☔ View full report in Codecov by Sentry. |
not sure how but this is failing on main: https://cloud.nx.app/runs/oblIhu1Dfj
Can you please investigate and fix it, or I need to revert. Thanks |
@TkDodo Revert first please not to affect other branches working, I will investigate it soon |
@TkDodo, I started to investigate this issue in QuiiBz/sherif#51 |
@TkDodo I saw your feature request in QuiiBz/sherif#41 and feature is added in v7.0.0 of sherif
Thanks to request feature to sherif. I am using this tool and this I needed this feature too.
To resolve your comment in #6686 I updated script for sherif. from now we don't have to use unnecessary option(-i react-scripts -i typescript) So cool👍