Skip to content

chore: add eslint test script to package.json #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

chore: add eslint test script to package.json #8979

merged 2 commits into from
Apr 9, 2025

Conversation

Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Apr 9, 2025 •
edited
Loading

No description provided.

@Newbie012
chore: add eslint test script to package.json
a3ca331 
Add a new script "test:eslint" to run eslint on the src directory, improving code quality checks during development.
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a2a6463.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 47s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 15:43:07 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 9, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8979

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8979

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8979

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8979

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8979

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8979

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8979

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8979

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8979

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8979

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8979

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8979

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8979

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8979

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8979

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8979

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8979

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8979

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8979

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8979

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8979

commit: a2a6463

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

Sizes for commit a2a6463:

Branch Bundle Size
Main
This PR

@Newbie012
fix(nx): ensure test eslint depends on build for plugin workspace
a2a6463 
Added nx configuration to make test:eslint target depend on the build target of its dependencies, ensuring the eslint plugin workspace is built before running tests.
@TkDodo TkDodo merged commit 7236237 into main Apr 9, 2025
5 checks passed
@TkDodo TkDodo deleted the restore-test-example branch April 9, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Newbie012 @TkDodo