Skip to content

Expand by click on dots #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Sep 22, 2022

I haven't tried to test in browser, but tests are passed.
BTW, didn't you think to add storybook?

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 3757a78
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/632cdff14264c50008e53d59
😎 Deploy Preview https://deploy-preview-76--any-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xepozz xepozz marked this pull request as draft September 22, 2022 21:54
@himself65
Copy link
Contributor

I haven't tried to test in browser, but tests are passed. BTW, didn't you think to add storybook?

I don't like storybooks since they don't support React 18 at the beginning year... Test cases for now just make sure the render won't throw an error. I don't have much time for E2E testing because I've many side projects, and I'm focusing on documents now.
Anyway, we have only one component, which is JSONViewer, so I think we might no need a storybook, maybe other ways

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 89.47% // Head: 89.78% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (3757a78) compared to base (b2ea339).
Patch coverage: 56.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   89.47%   89.78%   +0.30%     
==========================================
  Files          18       18              
  Lines        1777     1781       +4     
  Branches      240      247       +7     
==========================================
+ Hits         1590     1599       +9     
+ Misses        187      182       -5     
Impacted Files Coverage Δ
src/components/DataTypes/Object.tsx 86.41% <56.41%> (+0.20%) ⬆️
src/hooks/useInspect.ts 100.00% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 marked this pull request as ready for review September 22, 2022 21:55
@xepozz
Copy link
Contributor Author

xepozz commented Sep 22, 2022

I haven't tried to test in browser, but tests are passed. BTW, didn't you think to add storybook?

I don't like storybooks since they don't support React 18 at the beginning year... Test cases for now just make sure the render won't throw an error. I don't have much time for E2E testing because I've many side projects, and I'm focusing on documents now. Anyway, we have only one component, which is JSONViewer, so I think we might no need a storybook, maybe other ways

I haven't noticed about netlify bot and it works good and partially replaces storybook.

@xepozz
Copy link
Contributor Author

xepozz commented Sep 23, 2022

@himself65 ready for review and next processing

@himself65 himself65 merged commit b4bb9d5 into TexteaInc:main Sep 23, 2022
@xepozz xepozz deleted the expand-by-click-on-dots branch September 23, 2022 13:38
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants