From a48c0a6c6d1912d95bfc1d7f8cc25b8c8a8efa79 Mon Sep 17 00:00:00 2001 From: Vadim Platonov Date: Fri, 3 May 2019 15:22:23 +0200 Subject: [PATCH 1/2] [Rust] Remove unnecessary mut qualifier in after_member --- .../uk/co/real_logic/sbe/generation/rust/RustGenerator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java index b71cd1df2f..c3c0d6dfd7 100644 --- a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java +++ b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java @@ -648,7 +648,7 @@ private static void writeGroupDecoderTopTypes( indent(out).append("}\n"); indent(out).append("#[inline]\n"); - indent(out, 1, "fn after_member(mut self) -> %s {\n", groupLevelNextDecoderType); + indent(out, 1, "fn after_member(self) -> %s {\n", groupLevelNextDecoderType); indent(out, 2).append("if self.index <= self.max_index {\n"); indent(out, 3).append("Either::Left(self)\n"); indent(out, 2).append("} else {\n").append(INDENT).append(INDENT).append(INDENT) From 2139ea114c540c926f0479f0bd3dbb39ce5d4a4f Mon Sep 17 00:00:00 2001 From: Vadim Platonov Date: Fri, 3 May 2019 15:23:49 +0200 Subject: [PATCH 2/2] [Rust] Do not derive Debug on packed struct See [#46043](https://github.com/rust-lang/rust/issues/46043). --- .../uk/co/real_logic/sbe/generation/rust/RustGenerator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java index c3c0d6dfd7..05f1975ce6 100644 --- a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java +++ b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/rust/RustGenerator.java @@ -197,7 +197,7 @@ private static void generateSingleBitSet(final List tokens, final OutputM final String setType = formatTypeName(beginToken.applicableTypeName()); try (Writer writer = outputManager.createOutput(setType + " bit set")) { - writer.append("#[derive(Debug,Default)]\n"); + writer.append("#[derive(Default)]\n"); writer.append("#[repr(C,packed)]\n"); final String rustPrimitiveType = rustTypeName(beginToken.encoding().primitiveType()); writer.append(format("pub struct %s(pub %s);\n", setType, rustPrimitiveType));