Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

feat: created new multiparser #52

Merged
merged 3 commits into from
Nov 30, 2020
Merged

feat: created new multiparser #52

merged 3 commits into from
Nov 30, 2020

Conversation

shinspiegel
Copy link
Contributor

Hi!

After we talk on the #35, I did created a new parser for this project. I did use as a base structure the parser from deligenius/multiparser.

Besides that I did change the try/catch block, know any error should be resolved in the request function instead of the API call, that's what you thought in the #35, right?

Any suggestions to improve this parser?

@shinspiegel shinspiegel requested a review from ije as a code owner November 28, 2020 15:43
@ije
Copy link
Member

ije commented Nov 28, 2020

well done Jeferson @shinspiegel , it looks so great, can you please add a simple testing?

@ije
Copy link
Member

ije commented Nov 28, 2020

thanks

@shinspiegel
Copy link
Contributor Author

shinspiegel commented Nov 29, 2020

Sure thing!
I did created a simple test, I did never used Deno.test before, I think it's working.
I guess it looks like Jest, which is nice to tell the truth.

Ps.: The test passed on the automated tooling, cool stuff!

@ije
Copy link
Member

ije commented Nov 30, 2020

so good!

@ije ije merged commit e2c5533 into alephjs:master Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants