Skip to content

Commit 35a01da

Browse files
stuartmorgan-gandroidseb
authored andcommitted
Revert "[shared_preferences] Add shared preferences devtools" (flutter#8314)
Reverts flutter#6749 This is failing the publish step: ``` Running 'build_and_copy' in shared_preferences_tool [build_and_copy] Building the extension Flutter web app... Could not find an option named "--web-renderer". Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. Unhandled exception: ProcessException: Failed with exit code: 64 Command: flutter build web --web-renderer canvaskit --pwa-strategy=offline-first --release --no-tree-shake-icons #0 BuildExtensionCommand._runProcess (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:134:7) <asynchronous suspension> flutter#1 BuildExtensionCommand.run (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:57:5) <asynchronous suspension> flutter#2 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> flutter#3 SharedStdIn.terminate (package:io/src/shared_stdin.dart:91:3) <asynchronous suspension> flutter#4 main (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/devtools_extensions.dart:16:3) <asynchronous suspension> ```
1 parent 1cdf59e commit 35a01da

39 files changed

+3
-5156
lines changed

CODEOWNERS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,3 @@ packages/local_auth/local_auth_windows/** @cbracken
124124
packages/path_provider/path_provider_windows/** @cbracken
125125
packages/shared_preferences/shared_preferences_windows/** @cbracken
126126
packages/url_launcher/url_launcher_windows/** @cbracken
127-
128-
# - DevTools extensions
129-
# @adsonpleal is the actual maintainer of shared_preferences_tool but is not yet a committer, so can't be listed as the owner.
130-
packages/shared_preferences/shared_preferences_tool/** @tarrinneal

packages/shared_preferences/shared_preferences/CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
## 2.4.0
2-
3-
* Adds shared preferences devtools extension
4-
51
## 2.3.3
62

73
* Clarifies scope of prefix handling in README.

packages/shared_preferences/shared_preferences/extension/devtools/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/shared_preferences/shared_preferences/extension/devtools/.pubignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/shared_preferences/shared_preferences/extension/devtools/config.yaml

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/shared_preferences/shared_preferences/lib/src/shared_preferences_async.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import 'package:flutter/foundation.dart';
88
import 'package:shared_preferences_platform_interface/shared_preferences_async_platform_interface.dart';
99
import 'package:shared_preferences_platform_interface/types.dart';
1010

11-
import 'shared_preferences_devtools_extension_data.dart';
12-
1311
/// Provides a persistent store for simple data.
1412
///
1513
/// Data is persisted to and fetched from the disk asynchronously.
@@ -403,10 +401,3 @@ class SharedPreferencesWithCache {
403401
return _cacheOptions.allowList?.contains(key) ?? true;
404402
}
405403
}
406-
407-
// Include an unused import to ensure this library is included
408-
// when running `flutter run -d chrome`.
409-
// Check this discussion for more info: https://github.com/flutter/packages/pull/6749/files/6eb1b4fdce1eba107294770d581713658ff971e9#discussion_r1755375409
410-
// ignore: unused_element
411-
final bool _fieldToKeepDevtoolsExtensionReachable =
412-
fieldToKeepDevtoolsExtensionLibraryAlive;

packages/shared_preferences/shared_preferences/lib/src/shared_preferences_devtools_extension_data.dart

Lines changed: 0 additions & 138 deletions
This file was deleted.

packages/shared_preferences/shared_preferences/lib/src/shared_preferences_legacy.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import 'package:flutter/foundation.dart' show visibleForTesting;
88
import 'package:shared_preferences_platform_interface/shared_preferences_platform_interface.dart';
99
import 'package:shared_preferences_platform_interface/types.dart';
1010

11-
import 'shared_preferences_devtools_extension_data.dart';
12-
1311
/// Wraps NSUserDefaults (on iOS) and SharedPreferences (on Android), providing
1412
/// a persistent store for simple data.
1513
///
@@ -287,10 +285,3 @@ Either update the implementation to support setPrefix, or do not call setPrefix.
287285
_completer = null;
288286
}
289287
}
290-
291-
// Include an unused import to ensure this library is included
292-
// when running `flutter run -d chrome`.
293-
// Check this discussion for more info: https://github.com/flutter/packages/pull/6749/files/6eb1b4fdce1eba107294770d581713658ff971e9#discussion_r1755375409
294-
// ignore: unused_element
295-
final bool _fieldToKeepDevtoolsExtensionReachable =
296-
fieldToKeepDevtoolsExtensionLibraryAlive;

packages/shared_preferences/shared_preferences/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
name: shared_preferences
2-
description: Flutter plugin for reading and writing simple key-value pairs. Wraps NSUserDefaults on iOS and SharedPreferences on Android.
2+
description: Flutter plugin for reading and writing simple key-value pairs.
3+
Wraps NSUserDefaults on iOS and SharedPreferences on Android.
34
repository: https://github.com/flutter/packages/tree/main/packages/shared_preferences/shared_preferences
45
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22
5-
version: 2.4.0
6+
version: 2.3.3
67

78
environment:
89
sdk: ^3.4.0
@@ -39,7 +40,6 @@ dev_dependencies:
3940
sdk: flutter
4041
integration_test:
4142
sdk: flutter
42-
path: ^1.9.0
4343

4444
topics:
4545
- persistence

0 commit comments

Comments
 (0)