Skip to content

Commit 7be8bb1

Browse files
wagnermacielatscott
authored andcommitted
revert: "revert: "feat(dev-infra): exposed new rule 'component_benchmark' via dev_infra (#36434)" (#36798)" (#36800)
This reverts commit ad8c4cd. PR Close #36800
1 parent c7c0c1f commit 7be8bb1

File tree

96 files changed

+191
-125
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+191
-125
lines changed

.pullapprove.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -968,23 +968,17 @@ groups:
968968
'docs/TOOLS.md',
969969
'docs/TRIAGE_AND_LABELS.md',
970970
'goldens/*',
971-
'modules/e2e_util/e2e_util.ts',
972-
'modules/e2e_util/perf_util.ts',
973971
'modules/*',
974972
'packages/*',
975973
'packages/examples/test-utils/**',
976974
'packages/private/**',
977975
'packages/examples/*',
978976
'scripts/**',
979977
'third_party/**',
980-
'tools/brotli-cli/**',
981-
'tools/browsers/**',
982978
'tools/build/**',
983979
'tools/circular_dependency_test/**',
984980
'tools/contributing-stats/**',
985-
'tools/components/**',
986981
'tools/gulp-tasks/**',
987-
'tools/ng_rollup_bundle/**',
988982
'tools/ngcontainer/**',
989983
'tools/npm/**',
990984
'tools/npm_integration_test/**',

BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package(default_visibility = ["//visibility:public"])
22

33
exports_files([
44
"LICENSE",
5-
"protractor-perf.conf.js",
65
"karma-js.conf.js",
76
"browser-providers.conf.js",
87
"scripts/ci/track-payload-size.sh",

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories"
6464

6565
web_test_repositories()
6666

67-
load("//tools/browsers:browser_repositories.bzl", "browser_repositories")
67+
load("//dev-infra/benchmark/browsers:browser_repositories.bzl", "browser_repositories")
6868

6969
browser_repositories()
7070

dev-infra/benchmark/BUILD.bazel

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
# Make source files available for distribution via pkg_npm
4+
filegroup(
5+
name = "files",
6+
srcs = glob(["*"]) + [
7+
"//dev-infra/benchmark/brotli-cli:files",
8+
"//dev-infra/benchmark/browsers:files",
9+
"//dev-infra/benchmark/component_benchmark:files",
10+
"//dev-infra/benchmark/ng_rollup_bundle:files",
11+
],
12+
)
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
4+
5+
nodejs_binary(
6+
name = "brotli-cli",
7+
data = [
8+
"cli.js",
9+
"@npm//brotli",
10+
],
11+
entry_point = ":cli.js",
12+
visibility = ["//visibility:public"],
13+
)
14+
15+
# Make source files available for distribution via pkg_npm
16+
filegroup(
17+
name = "files",
18+
srcs = glob(["*"]),
19+
)
File renamed without changes.

tools/browsers/BUILD.bazel renamed to dev-infra/benchmark/browsers/BUILD.bazel

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
#
1515
################################################################################
1616
#
17+
package(default_visibility = ["//visibility:public"])
18+
1719
load("@io_bazel_rules_webtesting//web:web.bzl", "browser", "web_test_archive")
1820

1921
# Override of chromium web_test_archive so that the archive is selected based on platform
@@ -31,7 +33,7 @@ web_test_archive(
3133
"@io_bazel_rules_webtesting//common/conditions:mac": {"CHROMIUM": "chrome-mac/Chromium.app/Contents/MacOS/chromium"},
3234
"@io_bazel_rules_webtesting//common/conditions:windows": {"CHROMIUM": "chrome-win/chrome.exe"},
3335
}),
34-
visibility = ["//tools/browsers:__subpackages__"],
36+
visibility = ["//dev-infra/benchmark/browsers:__subpackages__"],
3537
)
3638

3739
# Override of chromedriver web_test_archive so that the archive is selected based on platform
@@ -55,7 +57,7 @@ web_test_archive(
5557
"CHROMEDRIVER": "chromedriver_win32/chromedriver.exe",
5658
},
5759
}),
58-
visibility = ["//tools/browsers:__subpackages__"],
60+
visibility = ["//dev-infra/benchmark/browsers:__subpackages__"],
5961
)
6062

6163
browser(
@@ -68,3 +70,9 @@ browser(
6870
"@io_bazel_rules_webtesting//go/wsl",
6971
],
7072
)
73+
74+
# Make source files available for distribution via pkg_npm
75+
filegroup(
76+
name = "files",
77+
srcs = glob(["*"]),
78+
)
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
exports_files([
4+
"protractor-perf.conf.js",
5+
"start-server.js",
6+
])
7+
8+
# Make source files available for distribution via pkg_npm
9+
filegroup(
10+
name = "files",
11+
srcs = glob(["*"]) + ["//dev-infra/benchmark/component_benchmark/defaults:files"],
12+
)

0 commit comments

Comments
 (0)