Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

chore: add VSCode configuration and guide #11879

Merged
merged 1 commit into from
Mar 17, 2020
Merged

chore: add VSCode configuration and guide #11879

merged 1 commit into from
Mar 17, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 14, 2020 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

We have no default config for VSCode and no guide for VSCode users.

Issue Number:
Relates to #11844.

What is the new behavior?

  • add VSCode configuration and guide

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added type: chore P3: important Important issues that really should be fixed when possible. labels Mar 14, 2020
@Splaktar Splaktar added this to the 1.1.22 milestone Mar 14, 2020
@Splaktar Splaktar requested a review from andrewseguin March 14, 2020 08:01
@Splaktar Splaktar self-assigned this Mar 14, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 14, 2020
@Splaktar
Copy link
Contributor Author

@oliversalzburg PTAL.

oliversalzburg
oliversalzburg reviewed Mar 14, 2020
View reviewed changes
@oliversalzburg
Copy link
Contributor

Awesome. Really looking forward to this.

@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Mar 14, 2020
@Splaktar Splaktar requested a review from mmalerba March 17, 2020 09:45
mmalerba
mmalerba approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit a8954df into master Mar 17, 2020
@Splaktar Splaktar deleted the vscode branch March 17, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oliversalzburg oliversalzburg oliversalzburg left review comments

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: chore
Projects
None yet
Milestone
1.1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @oliversalzburg @mmalerba @googlebot