-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Correcting the hyperlink to redirect #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You're missing a "the" before "code of conduct", and for consistency with itself (if not much of the internet) "Swift.org" should be capitalized. Sorry to continue dragging this out! (Also, feel free to just squash commits and update the existing pull request rather than making a new one.) |
I am sorry for all the trouble. I have made the necessary changes. |
Didn't this all start because you wanted the "the" outside the link? :-) @mattt did agree with you there. What do you think? |
Haha! We are back to square one then. :) His statement didn't explicitly support my argument, although I think I must have missed out some meaning out there. |
Great. Let's go with this. Can you squash all the changes into a single commit? (You can force-push to update your pull request branch.) |
I am so sorry for the late update. There were a lot of merge conflicts and complexities and I am unable to squash all my commits to one. |
cool, let me know @KrishMunot if you want a hand with this |
@johnantoni I am looking into this and will update in a day or two. Thanks! :) |
Thanks @jrose-apple and @johnantoni , I have resolved this issue in another PR which is now merged |
Increase test timeout value by 4x https://bugs.swift.org/browse/SR-6792
Un-XFAIL Lark
No description provided.