Skip to content

Correcting the hyperlink to redirect #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

KrishMunot
Copy link
Contributor

No description provided.

@jrose-apple
Copy link
Contributor

You're missing a "the" before "code of conduct", and for consistency with itself (if not much of the internet) "Swift.org" should be capitalized.

Sorry to continue dragging this out!

(Also, feel free to just squash commits and update the existing pull request rather than making a new one.)

@jrose-apple jrose-apple self-assigned this Dec 8, 2015
@KrishMunot
Copy link
Contributor Author

I am sorry for all the trouble. I have made the necessary changes.
Thanks! :)

@jrose-apple
Copy link
Contributor

Didn't this all start because you wanted the "the" outside the link? :-) @mattt did agree with you there. What do you think?

@KrishMunot
Copy link
Contributor Author

Haha! We are back to square one then. :) His statement didn't explicitly support my argument, although I think I must have missed out some meaning out there.
Just made the correction and pushed a commit.

@jrose-apple
Copy link
Contributor

Great. Let's go with this. Can you squash all the changes into a single commit? (You can force-push to update your pull request branch.)

@KrishMunot
Copy link
Contributor Author

I am so sorry for the late update. There were a lot of merge conflicts and complexities and I am unable to squash all my commits to one.
I am submitting a new pull request to resolve this.

@johnantoni
Copy link
Contributor

cool, let me know @KrishMunot if you want a hand with this

@KrishMunot
Copy link
Contributor Author

@johnantoni I am looking into this and will update in a day or two. Thanks! :)

@KrishMunot
Copy link
Contributor Author

Thanks @jrose-apple and @johnantoni , I have resolved this issue in another PR which is now merged

@KrishMunot KrishMunot changed the title Changing the hyperlink word in README.md Correcting the hyperlink to redirect Mar 1, 2017
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants