Skip to content

Jira 792, Support addition UUID types, git PR 386. #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SidLeung
Copy link
Contributor

Features added:

  1. Add the support for two addition UUID types,
    UUID16_SOME and UUID128_SOME. These types,
    practically, behaves the same as their related
    ALL types. Sandeep found that the Apple devices
    made use of these additional types and requested
    for their support.

File mods:

  1. BLEDeviceManager.cpp:
    • Add UUID16_SOME and UUID128_SOME at places
      checking for UUID types.

@SidLeung SidLeung added this to the Deneb milestone Feb 16, 2017
@SidLeung SidLeung self-assigned this Feb 16, 2017
@SidLeung
Copy link
Contributor Author

@bigdinotech , @eriknyquist , please review the code.

@noelpaz , @russmcinnis , this PR is based on Sandeep's PR 386 and has been unit tested.

@SidLeung SidLeung force-pushed the master branch 2 times, most recently from ff32c97 to 174d276 Compare February 16, 2017 20:04
1. Add the descriptor's read feature.
2. Fix the bug when add multi-descriptor
3. Add the comments for APIs
@SidLeung
Copy link
Contributor Author

Corrected the issue of not using a branch in my repo to point to this PR. Closing this PR and replaced it with #450. This PR has been approved and ready to merge. Will do that with #450 instead.

@SidLeung SidLeung closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants