Skip to content

Commit 467a4ed

Browse files
Migrate TestRemoveMultipleArguments from test_config.py to config_test.go
1 parent 0105ca6 commit 467a4ed

File tree

2 files changed

+40
-29
lines changed

2 files changed

+40
-29
lines changed

internal/integrationtest/config/config_test.go

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,3 +479,43 @@ func TestRemoveSingleArgument(t *testing.T) {
479479
require.NoError(t, err)
480480
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[\"https://example.com/yet_another_package_example_index.json\"]")
481481
}
482+
483+
func TestRemoveMultipleArguments(t *testing.T) {
484+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
485+
defer env.CleanUp()
486+
487+
// Create a config file
488+
_, _, err := cli.Run("config", "init", "--dest-dir", ".")
489+
require.NoError(t, err)
490+
491+
// Adds URLs
492+
urls := [2]string{
493+
"https://example.com/package_example_index.json",
494+
"https://example.com/yet_another_package_example_index.json",
495+
}
496+
_, _, err = cli.Run("config", "add", "board_manager.additional_urls", urls[0], urls[1])
497+
require.NoError(t, err)
498+
499+
// Verifies default state
500+
stdout, _, err := cli.Run("config", "dump", "--format", "json")
501+
require.NoError(t, err)
502+
requirejson.Query(t, stdout, ".board_manager | .additional_urls | length", "2")
503+
requirejson.Contains(t, stdout, `
504+
{
505+
"board_manager": {
506+
"additional_urls": [
507+
"https://example.com/package_example_index.json",
508+
"https://example.com/yet_another_package_example_index.json"
509+
]
510+
}
511+
}`)
512+
513+
// Remove all URLs
514+
_, _, err = cli.Run("config", "remove", "board_manager.additional_urls", urls[0], urls[1])
515+
require.NoError(t, err)
516+
517+
// Verifies all URLs have been removed
518+
stdout, _, err = cli.Run("config", "dump", "--format", "json")
519+
require.NoError(t, err)
520+
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[]")
521+
}

test/test_config.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,6 @@
1717
import yaml
1818

1919

20-
def test_remove_multiple_arguments(run_command):
21-
# Create a config file
22-
assert run_command(["config", "init", "--dest-dir", "."])
23-
24-
# Adds URLs
25-
urls = [
26-
"https://example.com/package_example_index.json",
27-
"https://example.com/yet_another_package_example_index.json",
28-
]
29-
assert run_command(["config", "add", "board_manager.additional_urls"] + urls)
30-
31-
# Verifies default state
32-
result = run_command(["config", "dump", "--format", "json"])
33-
assert result.ok
34-
settings_json = json.loads(result.stdout)
35-
assert 2 == len(settings_json["board_manager"]["additional_urls"])
36-
assert urls[0] in settings_json["board_manager"]["additional_urls"]
37-
assert urls[1] in settings_json["board_manager"]["additional_urls"]
38-
39-
# Remove all URLs
40-
assert run_command(["config", "remove", "board_manager.additional_urls"] + urls)
41-
42-
# Verifies all URLs have been removed
43-
result = run_command(["config", "dump", "--format", "json"])
44-
assert result.ok
45-
settings_json = json.loads(result.stdout)
46-
assert [] == settings_json["board_manager"]["additional_urls"]
47-
48-
4920
def test_remove_on_unsupported_key(run_command):
5021
# Create a config file
5122
assert run_command(["config", "init", "--dest-dir", "."])

0 commit comments

Comments
 (0)