Migrated TestBoardList from test_board.py to board_test.go

I could not properly check if the test was working as intended because the command `board list --format json` returned an empty list if executed locally.
Further improvements could be done regarding the type of ports, which I suspect should be `map[string][]string` and not simply `[]string`.

Author: MatteoPologruto

internal/integrationtest/board/board_test.go

@@ -0,0 +1,55 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2022 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to [email protected].
+
+package board_t_test
+
+import (
+	"encoding/json"
+	"os"
+	"testing"
+
+	"github.com/arduino/arduino-cli/internal/integrationtest"
+	"github.com/arduino/go-paths-helper"
+	"github.com/stretchr/testify/require"
+	"go.bug.st/testsuite"
+)
+
+func TestBoardList(t *testing.T) {
+	if os.Getenv("CI") != "" {
+		t.Skip("VMs have no serial ports")
+	}
+
+	env := testsuite.NewEnvironment(t)
+	defer env.CleanUp()
+
+	cli := integrationtest.NewArduinoCliWithinEnvironment(env, &integrationtest.ArduinoCLIConfig{
+		ArduinoCLIPath:         paths.New("..", "..", "..", "arduino-cli"),
+		UseSharedStagingFolder: true,
+	})
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+	stdout, _, err := cli.Run("board", "list", "--format", "json")
+	require.NoError(t, err)
+	// check is a valid json and contains a list of ports
+	var ports []string
+	err = json.Unmarshal(stdout, &ports)
+	require.NoError(t, err)
+	require.NotEmpty(t, ports)
+	for _, port := range ports {
+		require.Contains(t, port, "protocol")
+		require.Contains(t, port, "protocol_label")
+	}
+}

test/test_board.py

@@ -394,19 +394,6 @@
 """  # noqa: E501
 
 
-@pytest.mark.skipif(running_on_ci(), reason="VMs have no serial ports")
-def test_board_list(run_command):
-    run_command(["core", "update-index"])
-    result = run_command(["board", "list", "--format", "json"])
-    assert result.ok
-    # check is a valid json and contains a list of ports
-    ports = json.loads(result.stdout)
-    assert isinstance(ports, list)
-    for port in ports:
-        assert "protocol" in port["port"]
-        assert "protocol_label" in port["port"]
-
-
 def test_board_list_with_invalid_discovery(run_command, data_dir):
     run_command(["core", "update-index"])
     result = run_command(["board", "list"])