Moved some runtime build path properties to proper function

Author: cmaglie

arduino/cores/cores.go

@@ -336,8 +336,8 @@ func (release *PlatformRelease) RequiresToolRelease(toolRelease *ToolRelease) bo
 func (release *PlatformRelease) RuntimeProperties() *properties.Map {
 	res := properties.NewMap()
 	if release.InstallDir != nil {
-		res.Set("runtime.platform.path", release.InstallDir.String())
-		res.Set("runtime.hardware.path", release.InstallDir.Join("..").String())
+		res.SetPath("runtime.platform.path", release.InstallDir)
+		res.SetPath("runtime.hardware.path", release.InstallDir.Join(".."))
 	}
 
 	return res

arduino/cores/packagemanager/package_manager.go

@@ -317,6 +317,11 @@ func (pme *Explorer) ResolveFQBN(fqbn *cores.FQBN) (
 		}
 	}
 
+	// Runtime build properties
+	buildProperties.Merge(platformRelease.RuntimeProperties())
+	buildProperties.SetPath("build.core.path", buildPlatformRelease.InstallDir.Join("cores", coreParts[0]))
+	buildProperties.SetPath("build.system.path", buildPlatformRelease.InstallDir.Join("system"))
+
 	// No errors... phew!
 	return targetPackage, platformRelease, board, buildProperties, buildPlatformRelease, nil
 }

legacy/builder/setup_build_properties.go

@@ -57,10 +57,6 @@ func (s *SetupBuildProperties) Run(ctx *types.Context) error {
 	}
 
 	buildProperties.Set("build.core", ctx.BuildCore)
-	buildProperties.SetPath("build.core.path", actualPlatform.InstallDir.Join("cores", buildProperties.Get("build.core")))
-	buildProperties.Set("build.system.path", actualPlatform.InstallDir.Join("system").String())
-	buildProperties.Set("runtime.platform.path", targetPlatform.InstallDir.String())
-	buildProperties.Set("runtime.hardware.path", targetPlatform.InstallDir.Join("..").String())
 	buildProperties.Set("runtime.ide.version", ctx.ArduinoAPIVersion)
 	buildProperties.Set("runtime.ide.path", exPath)
 	buildProperties.Set("ide_version", ctx.ArduinoAPIVersion)