Rearrange protobuf files (#251)

* move protobuf definitions under rpc/commands

* move commands daemon into commands folder

* make client a test case

* run protoc as part of the testing pipeline

Author: masci

.travis.yml

@@ -4,7 +4,7 @@ go:
   - 1.12.x
 
 env:
-  - GO111MODULE=on
+  - GO111MODULE=on PATH=$HOME/protobuf/bin:$PATH
 
 # Anything in before_script that returns a nonzero exit code will flunk the
 # build and immediately stop. It's sorta like having set -e enabled in bash.
@@ -13,17 +13,22 @@ install:
   - curl -sL https://taskfile.dev/install.sh | sh
   - go get github.com/golangci/govet
   - go get golang.org/x/lint/golint
+  - go get -u github.com/golang/protobuf/protoc-gen-go
+  - |
+    mkdir -p $HOME/protobuf && pushd $HOME/protobuf &&
+    curl -LO 'https://github.com/google/protobuf/releases/download/v3.8.0/protoc-3.8.0-linux-x86_64.zip' &&
+    unzip protoc-3.8.0-linux-x86_64.zip &&
+    popd
 
 script:
   # Check if the code is formatted and run linter
   - ./bin/task check
   # Build and test
+  - ./bin/task protoc
   - ./bin/task build
   - ./bin/task test
   - ./bin/task test-legacy
 
 after_success:
   - bash <(curl -s https://codecov.io/bash) -cF unit -f '*_unit.txt'
   - bash <(curl -s https://codecov.io/bash) -cF integ -f '*_integ.txt'
-
-

Taskfile.yml

@@ -1,6 +1,11 @@
 version: '2'
 
 tasks:
+  protoc:
+    desc: Compile protobuf definitions
+    cmds:
+      - protoc --proto_path=rpc --go_out=plugins=grpc,paths=source_relative:rpc ./rpc/commands/*.proto
+
   build:
     desc: Build the project
     cmds:
@@ -45,6 +50,11 @@ tasks:
       - test -z $(go fmt ./legacy/...)
       - go vet ./legacy/...
 
+  rpc-client:
+    desc: Run the rpc client test routine (server must be already started)
+    cmds:
+      - go test -run TestWithClientE2E ./commands/daemon
+
 vars:
   # all modules of this project except for "legacy/..." module
   DEFAULT_TARGETS:
@@ -67,4 +77,4 @@ vars:
     -X github.com/arduino/arduino-cli/version.commit={{.TEST_COMMIT}}'
 
   # check-lint vars
-  GOLINTFLAGS: "-min_confidence 0.8 -set_exit_status"
+  GOLINTFLAGS: "-min_confidence 0.8 -set_exit_status"

cli/board/attach.go

@@ -24,7 +24,7 @@ import (
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/common/formatter"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/spf13/cobra"
 )
 

cli/board/details.go

@@ -26,7 +26,7 @@ import (
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/output"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/spf13/cobra"
 )
 

cli/board/list.go

@@ -28,7 +28,7 @@ import (
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/output"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/spf13/cobra"
 )
 

cli/board/listall.go

@@ -27,7 +27,7 @@ import (
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/output"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/spf13/cobra"
 )
 

cli/cli.go

@@ -31,7 +31,7 @@ import (
 	"github.com/arduino/arduino-cli/commands"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/configs"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/arduino/arduino-cli/version"
 	"github.com/arduino/go-paths-helper"
 	"github.com/sirupsen/logrus"

cli/compile/compile.go

@@ -24,7 +24,7 @@ import (
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/compile"
 	"github.com/arduino/arduino-cli/common/formatter"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/arduino/go-paths-helper"
 	"github.com/spf13/cobra"
 )

cli/core/download.go

@@ -24,7 +24,7 @@ import (
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/core"
 	"github.com/arduino/arduino-cli/common/formatter"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 )

cli/core/install.go

@@ -24,7 +24,7 @@ import (
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/core"
 	"github.com/arduino/arduino-cli/common/formatter"
-	"github.com/arduino/arduino-cli/rpc"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 )