cli: board listall use feedback result structs

Author: alessio-perugini

internal/cli/board/listall.go

@@ -23,6 +23,7 @@ import (
 
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/internal/cli/feedback"
+	fResult "github.com/arduino/arduino-cli/internal/cli/feedback/result"
 	"github.com/arduino/arduino-cli/internal/cli/instance"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 	"github.com/arduino/arduino-cli/table"
@@ -63,32 +64,40 @@ func runListAllCommand(cmd *cobra.Command, args []string) {
 		feedback.Fatal(tr("Error listing boards: %v", err), feedback.ErrGeneric)
 	}
 
-	feedback.PrintResult(resultAll{list})
+	feedback.PrintResult(resultAll{fResult.NewBoardListAllResponse(list)})
 }
 
 // output from this command requires special formatting, let's create a dedicated
 // feedback.Result implementation
 type resultAll struct {
-	list *rpc.BoardListAllResponse
+	list *fResult.BoardListAllResponse
 }
 
 func (dr resultAll) Data() interface{} {
 	return dr.list
 }
 
 func (dr resultAll) String() string {
+	t := table.New()
+	t.SetHeader(tr("Board Name"), tr("FQBN"), "")
+
+	if dr.list == nil || len(dr.list.Boards) == 0 {
+		return t.Render()
+	}
+
 	sort.Slice(dr.list.Boards, func(i, j int) bool {
-		return dr.list.Boards[i].GetName() < dr.list.Boards[j].GetName()
+		return dr.list.Boards[i].Name < dr.list.Boards[j].Name
 	})
 
-	t := table.New()
-	t.SetHeader(tr("Board Name"), tr("FQBN"), "")
-	for _, item := range dr.list.GetBoards() {
+	for _, item := range dr.list.Boards {
+		if item == nil {
+			continue
+		}
 		hidden := ""
 		if item.IsHidden {
 			hidden = tr("(hidden)")
 		}
-		t.AddRow(item.GetName(), item.GetFqbn(), hidden)
+		t.AddRow(item.Name, item.Fqbn, hidden)
 	}
 	return t.Render()
 }