refactor TempFileCreationFailedError to be FileCreationFailedError

Author: umbynos

arduino/errors.go

@@ -698,21 +698,22 @@ func (e *TempDirCreationFailedError) ToRPCStatus() *status.Status {
 	return status.New(codes.Unavailable, e.Error())
 }
 
-// TempFileCreationFailedError is returned if a temp file could not be created
-type TempFileCreationFailedError struct {
-	Cause error
+// FileCreationFailedError is returned if a temp file could not be created
+type FileCreationFailedError struct {
+	Message string
+	Cause   error
 }
 
-func (e *TempFileCreationFailedError) Error() string {
-	return composeErrorMsg(tr("Cannot create temp file"), e.Cause)
+func (e *FileCreationFailedError) Error() string {
+	return composeErrorMsg(e.Message, e.Cause)
 }
 
-func (e *TempFileCreationFailedError) Unwrap() error {
+func (e *FileCreationFailedError) Unwrap() error {
 	return e.Cause
 }
 
 // ToRPCStatus converts the error into a *status.Status
-func (e *TempFileCreationFailedError) ToRPCStatus() *status.Status {
+func (e *FileCreationFailedError) ToRPCStatus() *status.Status {
 	return status.New(codes.Unavailable, e.Error())
 }
 

commands/instances.go

@@ -469,9 +469,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB Do
 
 		var tmp *paths.Path
 		if tmpFile, err := ioutil.TempFile("", ""); err != nil {
-			return nil, &arduino.TempFileCreationFailedError{Cause: err}
+			return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
 		} else if err := tmpFile.Close(); err != nil {
-			return nil, &arduino.TempFileCreationFailedError{Cause: err}
+			return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
 		} else {
 			tmp = paths.New(tmpFile.Name())
 		}
@@ -502,9 +502,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB Do
 			URLSig.Path += ".sig"
 
 			if t, err := ioutil.TempFile("", ""); err != nil {
-				return nil, &arduino.TempFileCreationFailedError{Cause: err}
+				return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
 			} else if err := t.Close(); err != nil {
-				return nil, &arduino.TempFileCreationFailedError{Cause: err}
+				return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
 			} else {
 				tmpSig = paths.New(t.Name())
 			}