Skip to content

Added forum slug to products missing them #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

jhansson-ard
Copy link
Contributor

@jhansson-ard jhansson-ard commented Jan 24, 2024

What This PR Changes

To make the footer of the products contextual to the product page we are on, we can add the forumCategorySlug to link to the relevant forum category.

This PR updates all products under the maker umbrella.

Contribution Guidelines

Copy link

docs-content

🚀 Preview this PR: https://cc5fcf06.docs-content.pages.dev
📍 Commit SHA: e20b1fb

@jhansson-ard jhansson-ard added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team maker labels Jan 25, 2024
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhansson-ard looks good to me, but all URLs should contain a /c/ before the slug, otherwise its a 404. For example:

If that's intentional then I can go ahead and approve it.

@jhansson-ard
Copy link
Contributor Author

Yes, this will be added in the pattern @Matteo-it is creating 🙌🏼

@karlsoderby karlsoderby self-requested a review January 29, 2024 08:38
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, then all good @jhansson-ard

@jhansson-ard jhansson-ard merged commit e4a2486 into main Jan 29, 2024
@jhansson-ard jhansson-ard deleted the jhansson-ard/forum-slug branch January 29, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants