Skip to content

Change repo for Beelan Library #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Change repo for Beelan Library #1631

merged 1 commit into from
Aug 3, 2022

Conversation

sabas1080
Copy link
Contributor

ElectronicCat now supports the Beelan library

the link has changed

Thnaks

@github-actions
Copy link
Contributor

Hi @sabas1080.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Jul 20, 2022
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/ElectronicCats/Beelan-LoRaWAN:

Linting library in Beelan-LoRaWAN
INFO: No header file found matching library name (Beelan_LoRaWAN.h). Best practices are for primary header filename to  
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Beelan LoRaWAN contains spaces. Although supported, best practices is to not use       
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Sketch(es) found outside examples and extras folders:                                    
           Beelan-LoRaWAN/test/testFullfrequency                                                  
           Beelan-LoRaWAN/test/testOTAA                                                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in Beelan-LoRaWAN/examples/class-C-ABP

Linter results for project: no errors or warnings

-------------------

Linting sketch in Beelan-LoRaWAN/examples/send-class-A-ABP

Linter results for project: no errors or warnings

-------------------

Linting sketch in Beelan-LoRaWAN/examples/send-class-A-OTAA

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot requested a review from per1234 July 20, 2022 14:51
@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Jul 21, 2022
@per1234
Copy link
Contributor

per1234 commented Jul 21, 2022

Hello @sabas1080. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@sabas1080
Copy link
Contributor Author

@per1234 Thanks

@umbynos
Copy link
Contributor

umbynos commented Aug 3, 2022

Solved in #1633 (comment)

@umbynos umbynos self-assigned this Aug 3, 2022
@umbynos umbynos merged commit 7a14662 into arduino:main Aug 3, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Aug 3, 2022
@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Apr 29, 2023
@per1234 per1234 removed the topic: modification Change existing list entry label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants