Rework host platform naming #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indygreg
force-pushed
the
indygreg/host-platform-cleanups
branch
2 times, most recently
from
d8bd68d to
cbe7a4b
Compare
"host platform" is this concept I invented very early in the project to encode the build machine os and architecture. I chose "linux64" to represent Linux x86-64. And for reasons I can't recall, I never qualified the macOS architecture into the name like I did for Linux. This commit refactors the string so that it is consistently `os_arch`. `linux64` becomes `linux_x86_64`. `macos` becomes `macos_x86_64` and `macos_arm64`. I'm doing this cleanup in service of native ARM Linux builds. `linux64` is ambiguous. And macOS not behaving the same was always wonky. Let's impose some consistency instead of layering hacks upon hacks.
indygreg
force-pushed
the
indygreg/host-platform-cleanups
branch
from
cbe7a4b to
6c123e9
Compare
zanieb
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"host platform" is this concept I invented very early in the project to encode the build machine os and architecture. I chose "linux64" to represent Linux x86-64. And for reasons I can't recall, I never qualified the macOS architecture into the name like I did for Linux.
This commit refactors the string so that it is consistently
os_arch.linux64becomeslinux_x86_64.macosbecomesmacos_x86_64andmacos_arm64.I'm doing this cleanup in service of native ARM Linux builds.
linux64is ambiguous. And macOS not behaving the same was always wonky. Let's impose some consistency instead of layering hacks upon hacks.