Revert "[ty] Offer "Did you mean...?" suggestions for unresolved from imports and unresolved attributes (#18705)" (#18721)

Author: AlexWaygood

_typos.toml

@@ -8,8 +8,6 @@ extend-exclude = [
     # words naturally. It's annoying to have to make all
     # of them actually words. So just ignore typos here.
     "crates/ty_ide/src/completion.rs",
-    # Same for "Did you mean...?" levenshtein tests.
-    "crates/ty_python_semantic/src/types/diagnostic/levenshtein.rs",
 ]
 
 [default.extend-words]

crates/ty/docs/rules.md

@@ -2167,57 +2167,6 @@ reveal_type(Foo.BAR.value)  # revealed: @Todo(Attribute access on enum classes)
 reveal_type(Foo.__members__)  # revealed: @Todo(Attribute access on enum classes)
 ```
 
-## Suggestions for obvious typos
-
-<!-- snapshot-diagnostics -->
-
-For obvious typos, we add a "Did you mean...?" suggestion to the diagnostic.
-
-```py
-import collections
-
-print(collections.dequee)  # error: [unresolved-attribute]
-```
-
-But the suggestion is suppressed if the only close matches start with a leading underscore:
-
-```py
-class Foo:
-    _bar = 42
-
-print(Foo.bar)  # error: [unresolved-attribute]
-```
-
-The suggestion is not suppressed if the typo itself starts with a leading underscore, however:
-
-```py
-print(Foo._barr)  # error: [unresolved-attribute]
-```
-
-And in method contexts, the suggestion is never suppressed if accessing an attribute on an instance
-of the method's enclosing class:
-
-```py
-class Bar:
-    _attribute = 42
-
-    def f(self, x: "Bar"):
-        # TODO: we should emit `[unresolved-attribute]` here, should have the same behaviour as `x.attribute` below
-        print(self.attribute)
-
-        # We give a suggestion here, even though the only good candidates start with underscores and the typo does not,
-        # because we're in a method context and `x` is an instance of the enclosing class.
-        print(x.attribute)  # error: [unresolved-attribute]
-
-class Baz:
-    def f(self, x: Bar):
-        # No suggestion is given here, because:
-        # - the good suggestions all start with underscores
-        # - the typo does not start with an underscore
-        # - We *are* in a method context, but `x` is not an instance of the enclosing class
-        print(x.attribute)  # error: [unresolved-attribute]
-```
-
 ## References
 
 Some of the tests in the *Class and instance variables* section draw inspiration from

crates/ty_python_semantic/resources/mdtest/attributes.md

@@ -205,39 +205,3 @@ python-version = "3.13"
 import aifc  # error: [unresolved-import]
 from distutils import sysconfig  # error: [unresolved-import]
 ```
-
-## `from` import that has a typo
-
-We offer a "Did you mean?" subdiagnostic suggestion if there's a name in the module that's
-reasonably similar to the unresolved member.
-
-<!-- snapshot-diagnostics -->
-
-`foo.py`:
-
-```py
-from collections import dequee  # error: [unresolved-import]
-```
-
-However, we suppress the suggestion if the only close matches in the module start with a leading
-underscore:
-
-`bar.py`:
-
-```py
-from baz import foo  # error: [unresolved-import]
-```
-
-`baz.py`:
-
-```py
-_foo = 42
-```
-
-The suggestion is never suppressed if the typo itself starts with a leading underscore, however:
-
-`eggs.py`:
-
-```py
-from baz import _fooo  # error: [unresolved-import]
-```

crates/ty_python_semantic/resources/mdtest/import/basic.md

@@ -10,7 +10,7 @@ use crate::module_resolver::{Module, resolve_module};
 use crate::semantic_index::ast_ids::HasScopedExpressionId;
 use crate::semantic_index::place::FileScopeId;
 use crate::semantic_index::semantic_index;
-use crate::types::all_members::all_declarations_and_bindings;
+use crate::types::ide_support::all_declarations_and_bindings;
 use crate::types::{Type, binding_type, infer_scope_types};
 
 pub struct SemanticModel<'db> {

crates/ty_python_semantic/resources/mdtest/snapshots/attributes.md_-_Attributes_-_Suggestions_for_obvi…_(bf7b28ef99f0ec16).snap

@@ -38,7 +38,6 @@ use crate::semantic_index::definition::Definition;
 use crate::semantic_index::place::{ScopeId, ScopedPlaceId};
 use crate::semantic_index::{imported_modules, place_table, semantic_index};
 use crate::suppression::check_suppressions;
-pub use crate::types::all_members::all_members;
 use crate::types::call::{Binding, Bindings, CallArgumentTypes, CallableBinding};
 pub(crate) use crate::types::class_base::ClassBase;
 use crate::types::context::{LintDiagnosticGuard, LintDiagnosticGuardBuilder};
@@ -47,6 +46,7 @@ use crate::types::function::{
     DataclassTransformerParams, FunctionSpans, FunctionType, KnownFunction,
 };
 use crate::types::generics::{GenericContext, PartialSpecialization, Specialization};
+pub use crate::types::ide_support::all_members;
 use crate::types::infer::infer_unpack_types;
 use crate::types::mro::{Mro, MroError, MroIterator};
 pub(crate) use crate::types::narrow::infer_narrowing_constraint;
@@ -58,7 +58,6 @@ use instance::Protocol;
 pub use instance::{NominalInstanceType, ProtocolInstanceType};
 pub use special_form::SpecialFormType;
 
-pub(crate) mod all_members;
 mod builder;
 mod call;
 mod class;
@@ -68,6 +67,7 @@ mod diagnostic;
 mod display;
 mod function;
 mod generics;
+pub(crate) mod ide_support;
 mod infer;
 mod instance;
 mod mro;

crates/ty_python_semantic/resources/mdtest/snapshots/basic.md_-_Structures_-_`from`_import_that_h…_(3caffc60d8390adf).snap

@@ -27,7 +27,7 @@ use crate::types::signatures::{Parameter, ParameterForm};
 use crate::types::{
     BoundMethodType, ClassLiteral, DataclassParams, KnownClass, KnownInstanceType,
     MethodWrapperKind, PropertyInstanceType, SpecialFormType, TupleType, TypeMapping, UnionType,
-    WrapperDescriptorKind, all_members, todo_type,
+    WrapperDescriptorKind, ide_support, todo_type,
 };
 use ruff_db::diagnostic::{Annotation, Diagnostic, Severity, SubDiagnostic};
 use ruff_python_ast as ast;
@@ -669,7 +669,7 @@ impl<'db> Bindings<'db> {
                             if let [Some(ty)] = overload.parameter_types() {
                                 overload.set_return_type(TupleType::from_elements(
                                     db,
-                                    all_members::all_members(db, *ty)
+                                    ide_support::all_members(db, *ty)
                                         .into_iter()
                                         .sorted()
                                         .map(|member| Type::string_literal(db, &member)),

crates/ty_python_semantic/src/semantic_model.rs

@@ -225,10 +225,6 @@ pub enum ClassType<'db> {
 
 #[salsa::tracked]
 impl<'db> ClassType<'db> {
-    pub(super) fn is_protocol(self, db: &'db dyn Db) -> bool {
-        self.class_literal(db).0.is_protocol(db)
-    }
-
     pub(super) fn normalized(self, db: &'db dyn Db) -> Self {
         match self {
             Self::NonGeneric(_) => self,