Skip to content

Commit 4112bae

Browse files
committed
API - Refactor rename ResponseListener to RequestListener #6
1 parent 9cdf255 commit 4112bae

File tree

7 files changed

+20
-20
lines changed

7 files changed

+20
-20
lines changed

client/src/main/java/io/avaje/http/client/DHttpClientContext.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ class DHttpClientContext implements HttpClientContext {
1515
private final String baseUrl;
1616
private final Duration requestTimeout;
1717
private final BodyAdapter bodyAdapter;
18-
private final ResponseListener responseListener;
18+
private final RequestListener requestListener;
1919

20-
DHttpClientContext(HttpClient httpClient, String baseUrl, Duration requestTimeout, BodyAdapter bodyAdapter, ResponseListener responseListener) {
20+
DHttpClientContext(HttpClient httpClient, String baseUrl, Duration requestTimeout, BodyAdapter bodyAdapter, RequestListener requestListener) {
2121
this.httpClient = httpClient;
2222
this.baseUrl = baseUrl;
2323
this.requestTimeout = requestTimeout;
2424
this.bodyAdapter = bodyAdapter;
25-
this.responseListener = responseListener;
25+
this.requestListener = requestListener;
2626
}
2727

2828
@Override
@@ -128,14 +128,14 @@ <T> List<T> readList(Class<T> cls, BodyContent content) {
128128

129129

130130
void afterResponse(DHttpClientRequest request) {
131-
if (responseListener != null) {
132-
responseListener.response(request.listenerEvent());
131+
if (requestListener != null) {
132+
requestListener.response(request.listenerEvent());
133133
}
134134
}
135135

136136
void afterResponseHandler(DHttpClientRequest request) {
137-
if (responseListener != null) {
138-
responseListener.response(request.listenerEvent());
137+
if (requestListener != null) {
138+
requestListener.response(request.listenerEvent());
139139
}
140140
}
141141
}

client/src/main/java/io/avaje/http/client/DHttpClientContextBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class DHttpClientContextBuilder implements HttpClientContext.Builder {
1818

1919
private BodyAdapter bodyAdapter;
2020

21-
private ResponseListener responseListener;
21+
private RequestListener requestListener;
2222

2323
private CookieHandler cookieHandler = new CookieManager();
2424

@@ -55,8 +55,8 @@ public HttpClientContext.Builder withBodyAdapter(BodyAdapter adapter) {
5555
}
5656

5757
@Override
58-
public HttpClientContext.Builder withResponseListener(ResponseListener responseListener) {
59-
this.responseListener = responseListener;
58+
public HttpClientContext.Builder withRequestListener(RequestListener requestListener) {
59+
this.requestListener = requestListener;
6060
return this;
6161
}
6262

@@ -89,7 +89,7 @@ public HttpClientContext build() {
8989
if (client == null) {
9090
client = defaultClient();
9191
}
92-
return new DHttpClientContext(client, baseUrl, requestTimeout, bodyAdapter, responseListener);
92+
return new DHttpClientContext(client, baseUrl, requestTimeout, bodyAdapter, requestListener);
9393
}
9494

9595
private HttpClient defaultClient() {

client/src/main/java/io/avaje/http/client/DHttpClientRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,11 +354,11 @@ protected HttpRequest.Builder newRequest(String method, String url, HttpRequest.
354354
.method(method, body);
355355
}
356356

357-
ResponseListener.Event listenerEvent() {
357+
RequestListener.Event listenerEvent() {
358358
return new ListenerEvent();
359359
}
360360

361-
private class ListenerEvent implements ResponseListener.Event {
361+
private class ListenerEvent implements RequestListener.Event {
362362

363363
@Override
364364
public long responseTimeNanos() {

client/src/main/java/io/avaje/http/client/HttpClientContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,11 @@ interface Builder {
151151
Builder withBodyAdapter(BodyAdapter adapter);
152152

153153
/**
154-
* Add a response listener. Note that {@link RequestLogger} is an
154+
* Add a request listener. Note that {@link RequestLogger} is an
155155
* implementation for debug logging request/response headers and
156156
* content.
157157
*/
158-
Builder withResponseListener(ResponseListener requestListener);
158+
Builder withRequestListener(RequestListener requestListener);
159159

160160
/**
161161
* Specify a cookie handler to use on the HttpClient. This would override the default cookie handler.

client/src/main/java/io/avaje/http/client/ResponseListener.java renamed to client/src/main/java/io/avaje/http/client/RequestListener.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
/**
88
* Listen to responses.
99
* <p>
10-
* {@link RequestLogger} is an implementation for debug logging the
11-
* requests and responses.
10+
* {@link RequestLogger} is an implementation for debug logging
11+
* the requests and responses.
1212
*/
13-
public interface ResponseListener {
13+
public interface RequestListener {
1414

1515
/**
1616
* Handle the response.

client/src/main/java/io/avaje/http/client/RequestLogger.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
/**
1414
* Logs request and response details for debug logging purposes.
1515
*/
16-
public class RequestLogger implements ResponseListener {
16+
public class RequestLogger implements RequestListener {
1717

1818
private static final Logger log = LoggerFactory.getLogger(RequestLogger.class);
1919

client/src/test/java/io/avaje/http/client/BaseWebTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public static void shutdown() {
2626
public static HttpClientContext client() {
2727
return HttpClientContext.newBuilder()
2828
.withBaseUrl(baseUrl)
29-
.withResponseListener(new RequestLogger())
29+
.withRequestListener(new RequestLogger())
3030
.withBodyAdapter(new JacksonBodyAdapter(new ObjectMapper()))
3131
// .withBodyAdapter(new GsonBodyAdapter(new Gson()))
3232
.build();

0 commit comments

Comments
 (0)