Skip to content

Commit d205ca4

Browse files
committed
chore(tests): remove redundant override test
1 parent fbffe48 commit d205ca4

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

tests/functional/test_utilities_parameters.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1769,36 +1769,6 @@ def _get_parameters_by_name(
17691769
assert values[decrypt_param_two] == decrypted_response
17701770

17711771

1772-
def test_get_parameters_by_name_with_overrides(monkeypatch, mock_value):
1773-
# GIVEN 1 out of 2 parameters overrides max_age to 0
1774-
no_cache_param = "/no_cache"
1775-
json_param = "/json"
1776-
params = {no_cache_param: {"max_age": 0}, json_param: {"transform": "json"}}
1777-
1778-
stub_params = {no_cache_param: mock_value, json_param: '{"a":"b"}'}
1779-
stub_response = build_get_parameters_stub(params=stub_params)
1780-
1781-
class FakeClient:
1782-
def get_parameters(self, *args, **kwargs):
1783-
return stub_response
1784-
1785-
class TestProvider(SSMProvider):
1786-
def _get_parameters_by_name(
1787-
self, parameters: Dict[str, Dict], raise_on_error: bool = True, decrypt: bool = False
1788-
) -> Tuple[Dict[str, Any], List[str]]:
1789-
# THEN max_age should use no_cache_param override
1790-
assert parameters[no_cache_param]["max_age"] == 0
1791-
return super()._get_parameters_by_name(parameters, raise_on_error, decrypt)
1792-
1793-
provider = TestProvider(boto3_client=FakeClient())
1794-
monkeypatch.setitem(parameters.base.DEFAULT_PROVIDERS, "ssm", TestProvider(boto3_client=FakeClient()))
1795-
1796-
# WHEN get_parameters_by_name is called
1797-
ret = provider.get_parameters_by_name(parameters=params)
1798-
# THEN json_param should be transformed
1799-
assert isinstance(ret[json_param], dict)
1800-
1801-
18021772
def test_get_parameters_by_name_with_override_and_explicit_global(monkeypatch, mock_name, mock_value):
18031773
# GIVEN a parameter overrides a default setting
18041774
default_cache_period = 500

0 commit comments

Comments
 (0)