Skip to content

chore(clients): use @tsconfig/recommended and add tsconfig.cjs.json #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 14, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 13, 2022

Issue

This improvement idea came up while working on root TSConfigs in #3151
We use tsconfig.cjs.json in our monorepo, this change makes similar change for individual clients.

Description

Use tsconfig.cjs.json in build:cjs

Testing

  • CI
  • Integration tests are successful:
    • yarn test:integration
    • yarn test:integration:legacy
  • Documentation generation is successful:
    • yarn build:docs --clientDocs docs/clients/{{CLIENT}} --theme
    • ./node_modules/.bin/lerna exec --scope '@aws-sdk/client-*' --no-bail --stream -- yarn build:docs --out $(pwd)/docs/clients/$(basename \$LERNA_PACKAGE_NAME) --theme

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment has been minimized.

@trivikr trivikr marked this pull request as ready for review January 14, 2022 01:45
@trivikr trivikr changed the title chore(clients): use tsconfig.cjs.json in build:cjs chore(clients): use @tsconfig/recommended and add tsconfig.cjs.json Jan 14, 2022
@trivikr trivikr merged commit ebd5122 into aws:main Jan 14, 2022
@trivikr trivikr deleted the tsconfig-cjs-json branch January 14, 2022 18:54
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants