Skip to content

Commit 2f32a8e

Browse files
authored
Correct naming of ID parameter for NeptuneML Endpoint command (#217)
* Correct naming of ID parameter for NeptuneML endpoint command * Update endpoint_status ID help Co-authored-by: Michael Chin <[email protected]>
1 parent c07a592 commit 2f32a8e

6 files changed

+10
-10
lines changed

src/graph_notebook/magics/ml.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ def generate_neptune_ml_parser():
279279
endpoint_subparsers = parser_endpoint.add_subparsers(help='endpoint sub-command help',
280280
dest='which_sub')
281281
endpoint_start_parser = endpoint_subparsers.add_parser('create', help='create a new endpoint')
282-
endpoint_start_parser.add_argument('--job-id', type=str, default='')
282+
endpoint_start_parser.add_argument('--id', type=str, default='A unique identifier for the new inference endpoint.')
283283
endpoint_start_parser.add_argument('--model-training-job-id', type=str, default='',
284284
help='The job Id of the completed model-training job. '
285285
'You must supply either model-training-job-id or model-transform-job-id.')
@@ -313,7 +313,7 @@ def generate_neptune_ml_parser():
313313
endpoint_status_parser = endpoint_subparsers.add_parser('status',
314314
help='obtain the status of an existing endpoint '
315315
'creation job')
316-
endpoint_status_parser.add_argument('--job-id', type=str, default='')
316+
endpoint_status_parser.add_argument('--id', type=str, default='The ID of an existing inference endpoint.')
317317
endpoint_status_parser.add_argument('--store-to', type=str, default='', help='store result to this variable')
318318
endpoint_status_parser.add_argument('--wait', action='store_true',
319319
help='wait for the exporter to finish running')
@@ -635,7 +635,7 @@ def neptune_ml_endpoint(args: argparse.Namespace, client: Client, output: widget
635635
if args.which_sub == 'create':
636636
if params is None or params == '' or params == {}:
637637
params = {
638-
"id": args.job_id,
638+
"id": args.id,
639639
'instanceType': args.instance_type
640640
}
641641
if args.update:
@@ -699,9 +699,9 @@ def neptune_ml_endpoint(args: argparse.Namespace, client: Client, output: widget
699699
return create_endpoint_job
700700
elif args.which_sub == 'status':
701701
if args.wait:
702-
return wait_for_endpoint(args.job_id, client, output, args.wait_interval, args.wait_timeout)
702+
return wait_for_endpoint(args.id, client, output, args.wait_interval, args.wait_timeout)
703703
else:
704-
endpoint_status = client.endpoints_status(args.job_id)
704+
endpoint_status = client.endpoints_status(args.id)
705705
endpoint_status.raise_for_status()
706706
return endpoint_status.json()
707707
else:

src/graph_notebook/notebooks/04-Machine-Learning/Neptune-ML-01-Introduction-to-Node-Classification-Gremlin.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@
480480
"execution_count": null,
481481
"source": [
482482
"endpoint_params=f\"\"\"\n",
483-
"--job-id {training_job_name} \n",
483+
"--id {training_job_name}\n",
484484
"--model--training-job-id {training_job_name} \"\"\""
485485
],
486486
"outputs": [],

src/graph_notebook/notebooks/04-Machine-Learning/Neptune-ML-02-Introduction-to-Node-Regression-Gremlin.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@
476476
"outputs": [],
477477
"source": [
478478
"endpoint_params=f\"\"\"\n",
479-
"--job-id {training_job_name} \n",
479+
"--id {training_job_name}\n",
480480
"--model-training-job-id {training_job_name}\"\"\""
481481
]
482482
},

src/graph_notebook/notebooks/04-Machine-Learning/Neptune-ML-03-Introduction-to-Link-Prediction-Gremlin.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@
450450
"outputs": [],
451451
"source": [
452452
"endpoint_params=f\"\"\"\n",
453-
"--job-id {training_job_name} \n",
453+
"--id {training_job_name}\n",
454454
"--model-training-job-id {training_job_name}\"\"\""
455455
]
456456
},

src/graph_notebook/notebooks/04-Machine-Learning/Neptune-ML-04-Introduction-to-Edge-Classification-Gremlin.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@
479479
"outputs": [],
480480
"source": [
481481
"endpoint_params=f\"\"\"\n",
482-
"--job-id {training_job_name} \n",
482+
"--id {training_job_name}\n",
483483
"--model-training-job-id {training_job_name}\"\"\""
484484
]
485485
},

src/graph_notebook/notebooks/04-Machine-Learning/Neptune-ML-05-Introduction-to-Edge-Regression-Gremlin.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@
477477
"outputs": [],
478478
"source": [
479479
"endpoint_params=f\"\"\"\n",
480-
"--job-id {training_job_name} \n",
480+
"--id {training_job_name}\n",
481481
"--model-training-job-id {training_job_name}\"\"\""
482482
]
483483
},

0 commit comments

Comments
 (0)