Skip to content

Correct naming of ID parameter for NeptuneML Endpoint command #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/graph_notebook/magics/ml.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def generate_neptune_ml_parser():
endpoint_subparsers = parser_endpoint.add_subparsers(help='endpoint sub-command help',
dest='which_sub')
endpoint_start_parser = endpoint_subparsers.add_parser('create', help='create a new endpoint')
endpoint_start_parser.add_argument('--job-id', type=str, default='')
endpoint_start_parser.add_argument('--id', type=str, default='A unique identifier for the new inference endpoint.')
endpoint_start_parser.add_argument('--model-training-job-id', type=str, default='',
help='The job Id of the completed model-training job. '
'You must supply either model-training-job-id or model-transform-job-id.')
Expand Down Expand Up @@ -313,7 +313,7 @@ def generate_neptune_ml_parser():
endpoint_status_parser = endpoint_subparsers.add_parser('status',
help='obtain the status of an existing endpoint '
'creation job')
endpoint_status_parser.add_argument('--job-id', type=str, default='')
endpoint_status_parser.add_argument('--id', type=str, default='The ID of an existing inference endpoint.')
endpoint_status_parser.add_argument('--store-to', type=str, default='', help='store result to this variable')
endpoint_status_parser.add_argument('--wait', action='store_true',
help='wait for the exporter to finish running')
Expand Down Expand Up @@ -635,7 +635,7 @@ def neptune_ml_endpoint(args: argparse.Namespace, client: Client, output: widget
if args.which_sub == 'create':
if params is None or params == '' or params == {}:
params = {
"id": args.job_id,
"id": args.id,
'instanceType': args.instance_type
}
if args.update:
Expand Down Expand Up @@ -699,9 +699,9 @@ def neptune_ml_endpoint(args: argparse.Namespace, client: Client, output: widget
return create_endpoint_job
elif args.which_sub == 'status':
if args.wait:
return wait_for_endpoint(args.job_id, client, output, args.wait_interval, args.wait_timeout)
return wait_for_endpoint(args.id, client, output, args.wait_interval, args.wait_timeout)
else:
endpoint_status = client.endpoints_status(args.job_id)
endpoint_status = client.endpoints_status(args.id)
endpoint_status.raise_for_status()
return endpoint_status.json()
else:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@
"execution_count": null,
"source": [
"endpoint_params=f\"\"\"\n",
"--job-id {training_job_name} \n",
"--id {training_job_name}\n",
"--model--training-job-id {training_job_name} \"\"\""
],
"outputs": [],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@
"outputs": [],
"source": [
"endpoint_params=f\"\"\"\n",
"--job-id {training_job_name} \n",
"--id {training_job_name}\n",
"--model-training-job-id {training_job_name}\"\"\""
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@
"outputs": [],
"source": [
"endpoint_params=f\"\"\"\n",
"--job-id {training_job_name} \n",
"--id {training_job_name}\n",
"--model-training-job-id {training_job_name}\"\"\""
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@
"outputs": [],
"source": [
"endpoint_params=f\"\"\"\n",
"--job-id {training_job_name} \n",
"--id {training_job_name}\n",
"--model-training-job-id {training_job_name}\"\"\""
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
"outputs": [],
"source": [
"endpoint_params=f\"\"\"\n",
"--job-id {training_job_name} \n",
"--id {training_job_name}\n",
"--model-training-job-id {training_job_name}\"\"\""
]
},
Expand Down