Skip to content

Support parquet load for Neptune Analytics #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

theneelshah
Copy link
Collaborator

@theneelshah theneelshah commented Jun 18, 2025

Issue #751:

Description of changes:

  • Add support for parquet format for incremental data load in AWS Neptune Analytics.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adityaramesh12
Copy link
Contributor

adityaramesh12 commented Jul 8, 2025

Modified the description message.
Can you verify/validate if incremental load with neptune database is possible as well? I think there is a condition that switches between incremental load and bulk load for neptune analytics v/s neptune. The code changes should be sufficient. But let's double check and document it here.
If that is not the case, we would need to add an explicit condition to only permit parquet load for Neptune Analytics.

@theneelshah theneelshah changed the title Support parquet bulk load for P8 Support parquet load for Neptune Analytics Jul 8, 2025
@theneelshah
Copy link
Collaborator Author

theneelshah commented Jul 14, 2025

Currently, the parquet format is only supported for incremental loads, which are exclusively used with Neptune Analytics. Bulk loads (used with Neptune DB) do not support the parquet format. This distinction is handled in the load magic function when processing the format parameter.

@theneelshah
Copy link
Collaborator Author

@adityaramesh12: Fixed the bug where edgeOnlyLoad parameter is passed for all bulk load formats. Currently, edgeOnlyLoad is only supported for CSV or Parquet format loads. Also, as per the previous comment, bulk load doesn't support parquet format loads. This behaviour might be changed and hence I have added a condition for parquet format for edgeOnlyLoad param.

Neel Shah and others added 5 commits July 16, 2025 10:36
* Add css variables from the Jupyter theme to be used for styling widget

* Create css variables based on Jupyter Labs' theme

+ Read the Jupyter Labs' css variables and give custom variable names.
+ Provide fallback values incase css variables not present or for backward compatibility.
+ Apply updated styles explicitly for custom SVG icons.

Tests:

+ The variables are applied to the global CSS.
+ The icons changes stroke color when theme is changed.

* Use the theme variables

+ Make the custom widget use the Jupyter Labs' theme variables

Tests:

+ The css for the widgets gets updated on theme change

* Fix typo

---------

Co-authored-by: Neel Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants