Skip to content

Commit 754271d

Browse files
committed
resolved comments.
1 parent fcca5e9 commit 754271d

File tree

5 files changed

+3
-27
lines changed

5 files changed

+3
-27
lines changed

bin/accessibility-automation/cypress/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,4 +378,4 @@ Cypress.Commands.add('getAccessibilityResults', () => {
378378

379379
} catch {}
380380

381-
});
381+
});

bin/helpers/atsHelper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,4 +113,4 @@ exports.atsFileCleanup = (bsConfig) => {
113113
if(fs.existsSync(filePath)){
114114
fs.unlinkSync(filePath);
115115
}
116-
}
116+
}

bin/testObservability/crashReporter/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,4 +170,4 @@ class CrashReporter {
170170
}
171171
}
172172

173-
module.exports = CrashReporter;
173+
module.exports = CrashReporter;

bin/testObservability/reporter/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ class MyReporter {
169169
})
170170

171171
.on(EVENT_TEST_BEGIN, async (test) => {
172-
debugOnConsole(`[MOCHA EVENT] EVENT_TEST_BEGIN`);
173172
debugOnConsole(`[MOCHA EVENT] EVENT_TEST_BEGIN for uuid: ${test.testAnalyticsId}`);
174173
if (this.runStatusMarkedHash[test.testAnalyticsId]) return;
175174
if(this.testObservability == true) {
@@ -178,7 +177,6 @@ class MyReporter {
178177
})
179178

180179
.on(EVENT_TEST_END, async (test) => {
181-
debugOnConsole(`[MOCHA EVENT] EVENT_TEST_END`);
182180
debugOnConsole(`[MOCHA EVENT] EVENT_TEST_BEGIN for uuid: ${test.testAnalyticsId}`);
183181
if (this.runStatusMarkedHash[test.testAnalyticsId]) return;
184182
if(this.testObservability == true) {

test/unit/bin/helpers/reporterHTML.js

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -226,28 +226,6 @@ describe('reporterHTML', () => {
226226
sendUsageReportStub.calledOnceWithExactly(bsConfig, args, message, messageType, errorCode, {}, rawArgs);
227227
});
228228
});
229-
230-
// describe('generateCypressBuildReport', () => {
231-
// it('calls cypress build report with report download url', () => {
232-
// let pathStub = sinon.stub(path, 'join');
233-
// let fileExistStub = sinon.stub(fs, 'existsSync');
234-
// let rewireReporterHTML = rewire('../../../../bin/helpers/reporterHTML');
235-
// let generateCypressBuildReport = rewireReporterHTML.__get__('generateCypressBuildReport');
236-
// let getReportResponseStub = sinon.stub();
237-
// getReportResponseStub.calledOnceWith('abc/efg', 'report.zip', 'url');
238-
// rewireReporterHTML.__set__('getReportResponse', getReportResponseStub);
239-
// pathStub.returns('abc/efg');
240-
// fileExistStub.returns(true);
241-
// generateCypressBuildReport({ report_data: 'url' });
242-
// pathStub.restore();
243-
// });
244-
245-
// reporterHTML.reportGenerator(bsConfig, buildId, args, rawArgs, {});
246-
247-
// sinon.assert.calledOnce(requestStub);
248-
// sinon.assert.calledOnce(getUserAgentStub);
249-
// sendUsageReportStub.calledOnceWithExactly(bsConfig, args, message, messageType, errorCode, {}, rawArgs);
250-
// });
251229
});
252230

253231
describe("unzipFile", () => {

0 commit comments

Comments
 (0)