Fixed local_mode not set to always-on when local_identifier is supplied in browserstack.json

Author: karanshah-browserstack

bin/helpers/utils.js

@@ -362,6 +362,11 @@ exports.setLocalIdentifier = (bsConfig, args) => {
       "Reading local identifier from the environment variable BROWSERSTACK_LOCAL_IDENTIFIER"
     );
     bsConfig['connection_settings']['local_mode'] = 'always-on';
+  } else if (
+      bsConfig['connection_settings']['local'] &&
+      !this.isUndefined(bsConfig["connection_settings"]["local_identifier"])
+    ){
+    bsConfig['connection_settings']['local_mode'] = 'always-on';
   } else if (
       bsConfig['connection_settings']['local'] &&
       this.isUndefined(bsConfig["connection_settings"]["local_identifier"])

test/unit/bin/helpers/utils.js

@@ -1114,7 +1114,19 @@ describe('utils', () => {
       utils.setLocalIdentifier(bsConfig, args);
       expect(bsConfig.connection_settings.local_identifier).to.be.eq("xyz");
       expect(bsConfig.connection_settings.local_mode).to.be.eq('always-on');
+    });
 
+    it('if localIdentifier is defined then local_mode is set to always-on' , () => {
+      let bsConfig = {
+        connection_settings: {
+          local: true,
+          local_identifier: 'abc',
+        },
+      };
+      let args = {}
+      utils.setLocalIdentifier(bsConfig, args);
+      expect(bsConfig.connection_settings.local_identifier).to.be.eq("abc");
+      expect(bsConfig['connection_settings']['local_mode']).to.be.eq('always-on');
     });
   });