Skip to content

Installing npm packages support win10 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 21, 2020
Merged

Conversation

suryart
Copy link
Collaborator

@suryart suryart commented May 8, 2020

Since mostly Cypress tests are written with external npm packages. We would like to enable the CLI user to be able to let us know the dependencies so that we can install them. Currently, this is limited only for Windows 10 machines.

This PR includes:

  • Adds npm_depedencies key to the browserstack.json config file.

archive.glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' });
archive
.glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' })
.append(packageJSON, { name: 'package.json' });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we take this out of forEach?

@suryart suryart force-pushed the npm-package-support-win10 branch from 7e3c4ca to 00ba670 Compare May 15, 2020 10:23
nagpalkaran95
nagpalkaran95 previously approved these changes May 21, 2020
Copy link
Collaborator

@nagpalkaran95 nagpalkaran95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -36,10 +36,13 @@ const archiveSpecs = (runSettings, filePath) => {

archive.pipe(output);

var packageJSON = JSON.stringify({devDependencies: runSettings.npm_dependencies}, null, 4);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to handle the case where the user is not setting any npm_dependencies or just removed the key manually.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@suryart suryart merged commit a2e86e6 into master May 21, 2020
@suryart suryart deleted the npm-package-support-win10 branch May 21, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants