Installing npm packages support win10 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck.json Removed package.json key dependency. Added config update command to update browserstack.json gracefully.
SagarGaniga
reviewed
May 11, 2020
bin/helpers/archiver.js
Outdated
| archive.glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' }); | ||
| archive | ||
| .glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' }) | ||
| .append(packageJSON, { name: 'package.json' }); |
There was a problem hiding this comment.
can we take this out of forEach?
suryart
force-pushed
the
npm-package-support-win10
branch
from
7e3c4ca to
00ba670
Compare
…-cli into npm-package-support-win10
SagarGaniga
reviewed
May 21, 2020
bin/helpers/archiver.js
Outdated
| @@ -36,10 +36,13 @@ const archiveSpecs = (runSettings, filePath) => { | |||
|
|
|||
| archive.pipe(output); | |||
|
|
|||
| var packageJSON = JSON.stringify({devDependencies: runSettings.npm_dependencies}, null, 4); | |||
There was a problem hiding this comment.
need to handle the case where the user is not setting any npm_dependencies or just removed the key manually.
SagarGaniga
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mostly Cypress tests are written with external npm packages. We would like to enable the CLI user to be able to let us know the dependencies so that we can install them. Currently, this is limited only for Windows 10 machines.
This PR includes:
npm_depedencieskey to the browserstack.json config file.