-
Notifications
You must be signed in to change notification settings - Fork 39
Installing npm packages support win10 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ck.json Removed package.json key dependency. Added config update command to update browserstack.json gracefully.
bin/helpers/archiver.js
Outdated
archive.glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' }); | ||
archive | ||
.glob(`**/*.${fileType}`, { cwd: cypressFolderPath, matchBase: true, ignore: 'node_modules/**' }) | ||
.append(packageJSON, { name: 'package.json' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we take this out of forEach?
7e3c4ca
to
00ba670
Compare
…-cli into npm-package-support-win10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bin/helpers/archiver.js
Outdated
@@ -36,10 +36,13 @@ const archiveSpecs = (runSettings, filePath) => { | |||
|
|||
archive.pipe(output); | |||
|
|||
var packageJSON = JSON.stringify({devDependencies: runSettings.npm_dependencies}, null, 4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to handle the case where the user is not setting any npm_dependencies
or just removed the key manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Since mostly Cypress tests are written with external npm packages. We would like to enable the CLI user to be able to let us know the dependencies so that we can install them. Currently, this is limited only for Windows 10 machines.
This PR includes:
npm_depedencies
key to the browserstack.json config file.