Skip to content

Feature: Enable GRR #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/commands/runs.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ module.exports = function run(args, rawArgs) {
// set cypress geo location
utils.setGeolocation(bsConfig, args);

// set spec timeout
// set spec timeout
utils.setSpecTimeout(bsConfig, args);

// accept the specs list from command line if provided
Expand Down Expand Up @@ -390,8 +390,8 @@ module.exports = function run(args, rawArgs) {
updateCheckInterval: 1000 * 60 * 60 * 24 * 7,
});

// Checks for update on first run.
// Set lastUpdateCheck to 0 to spawn the check update process as notifier sets this to Date.now() for preventing
// Checks for update on first run.
// Set lastUpdateCheck to 0 to spawn the check update process as notifier sets this to Date.now() for preventing
// the check untill one interval period. It runs once.
if (!notifier.disabled && Date.now() - notifier.config.get('lastUpdateCheck') < 50) {
notifier.config.set('lastUpdateCheck', 0);
Expand Down
3 changes: 3 additions & 0 deletions bin/helpers/getInitialDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ exports.getInitialDetails = (bsConfig, args, rawArgs) => {
utils.sendUsageReport(bsConfig, args, responseData["error"], Constants.messageTypes.ERROR, 'get_initial_details_failed', null, rawArgs);
resolve({});
} else {
if (!utils.isUndefined(responseData.grr) && responseData.grr.enabled && !utils.isUndefined(responseData.grr.urls)) {
config.uploadUrl = responseData.grr.urls.upload_url;
}
resolve(responseData);
}
}
Expand Down