Merge pull request #28 from browserstack/LOC_2717_json_parse_exception

bipul21 · web-flow · commit 78acbb6eaa18 · 2021-11-08T18:55:42.000+05:30
LOC 2717 catch JSON parse exception
diff --git a/BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs b/BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs
@@ -137,7 +137,12 @@ private void RunProcess(string arguments, string processType)
       {
         if (e.Data != null)
         {
-          JObject binaryOutput = JObject.Parse(e.Data);
+          JObject binaryOutput = null;
+          try {
+            binaryOutput = JObject.Parse(e.Data);
+          } catch (Exception) {
+            throw new Exception($"Error while parsing JSON {e.Data}");
+          }
           if(binaryOutput.GetValue("state") != null && !binaryOutput.GetValue("state").ToString().ToLower().Equals("connected"))
           {
             throw new Exception("Eror while executing BrowserStackLocal " + processType + " " + e.Data);

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,12 @@ private void RunProcess(string arguments, string processType)`
`137`	`137`	`{`
`138`	`138`	`if (e.Data != null)`
`139`	`139`	`{`
`140`		`- JObject binaryOutput = JObject.Parse(e.Data);`
	`140`	`+ JObject binaryOutput = null;`
	`141`	`+ try {`
	`142`	`+ binaryOutput = JObject.Parse(e.Data);`
	`143`	`+ } catch (Exception) {`
	`144`	`+ throw new Exception($"Error while parsing JSON {e.Data}");`
	`145`	`+ }`
`141`	`146`	`if(binaryOutput.GetValue("state") != null && !binaryOutput.GetValue("state").ToString().ToLower().Equals("connected"))`
`142`	`147`	`{`
`143`	`148`	`throw new Exception("Eror while executing BrowserStackLocal " + processType + " " + e.Data);`