Skip to content

docs: Publish website #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 8, 2019
Merged

Conversation

dcalhoun
Copy link
Contributor

@dcalhoun dcalhoun commented Feb 8, 2019

Summary

  • Remove unused Docusaurus code.
  • Add CI task for publishing website.

Fixes #26.


The CI task is the basic one provided by the Docusaurus guides. It has been awhile since I've interfaced with GitHub pages, it's also difficult to test without access to the repository. You may need to configure it further, but hopefully this provides a good starting place.

Test plan

  1. Merge this work.
  2. Configure CircleCI with GitHub token.
  3. Commit to master to trigger build and deployment.

Remove unused Docusaurus defaults as [requested](https://git.io/fh9po)
by [core maintainer](https://git.io/fh9p1).
Add required dependencies and package attributes to avoid yarn and lint
warnings.
While additional language translations have not been created, there did
not appear to be a reason to comment these props out.
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking that off!

@thymikee
Copy link
Member

thymikee commented Feb 8, 2019

Ok, let's give it a try!

@thymikee thymikee merged commit e17734f into callstack:master Feb 8, 2019
@dcalhoun dcalhoun deleted the docs/publish-website branch February 8, 2019 13:58
@thymikee
Copy link
Member

thymikee commented Feb 8, 2019

Works! https://callstack.github.io/react-native-testing-library/
Thank you so much for making that happen ❤️. If you have ideas for improvements (the website is pretty raw at this point) feel free to share them 👍

@dcalhoun
Copy link
Contributor Author

dcalhoun commented Feb 8, 2019

🎉 Awesome! I'll let you know if I encounter issues or have ideas for improvements. If your team produces a custom design, let me know and I may be able to find time to help execute it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants