From 66e540dd0d7924c3d498a4203060d3c41b5062e3 Mon Sep 17 00:00:00 2001
From: anishapm <anishamalde95@gmail.com>
Date: Thu, 28 Sep 2023 12:42:07 +0200
Subject: [PATCH 1/7] feat: toHaveAccessibleName matcher

---
 src/helpers/accessiblity.ts                   |  33 +++++-
 src/helpers/matchers/accessibilityName.ts     |  18 +++
 .../to-have-accessible-name.test.tsx          | 111 ++++++++++++++++++
 src/matchers/extend-expect.d.ts               |   1 +
 src/matchers/extend-expect.ts                 |   2 +
 src/matchers/index.ts                         |   1 +
 src/matchers/to-have-accessible-name.tsx      |  43 +++++++
 7 files changed, 208 insertions(+), 1 deletion(-)
 create mode 100644 src/helpers/matchers/accessibilityName.ts
 create mode 100644 src/matchers/__tests__/to-have-accessible-name.test.tsx
 create mode 100644 src/matchers/to-have-accessible-name.tsx

diff --git a/src/helpers/accessiblity.ts b/src/helpers/accessiblity.ts
index 7419d3356..b64644a0c 100644
--- a/src/helpers/accessiblity.ts
+++ b/src/helpers/accessiblity.ts
@@ -4,7 +4,7 @@ import {
   StyleSheet,
 } from 'react-native';
 import { ReactTestInstance } from 'react-test-renderer';
-import { getHostSiblings } from './component-tree';
+import { getHostSiblings, getHostParent } from './component-tree';
 import { getHostComponentNames } from './host-component-names';
 
 type IsInaccessibleOptions = {
@@ -233,3 +233,34 @@ export function isElementSelected(
   const { accessibilityState, 'aria-selected': ariaSelected } = element.props;
   return ariaSelected ?? accessibilityState?.selected ?? false;
 }
+
+export function getAccessibleName(
+  element: ReactTestInstance
+): string | undefined {
+  const labelTextFromLabel = getAccessibilityLabel(element);
+  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
+
+  if (labelTextFromLabelledBy) {
+    const parentElement = getHostParent(element);
+
+    if (parentElement) {
+      const labelElement = parentElement.findByProps({
+        nativeID: labelTextFromLabelledBy,
+      });
+
+      if (labelElement) {
+        // Extract and return the text content of the label element
+        const label = labelElement.props.children;
+        return label;
+      }
+    }
+  }
+
+  if (labelTextFromLabel) {
+    return labelTextFromLabel;
+  }
+
+  const ownText = element?.children?.join(' ');
+
+  return ownText || undefined;
+}
diff --git a/src/helpers/matchers/accessibilityName.ts b/src/helpers/matchers/accessibilityName.ts
new file mode 100644
index 000000000..e90d2bcca
--- /dev/null
+++ b/src/helpers/matchers/accessibilityName.ts
@@ -0,0 +1,18 @@
+import { ReactTestInstance } from 'react-test-renderer';
+import { getAccessibleName } from '../accessiblity';
+import { TextMatchOptions, matches, TextMatch } from '../../matches';
+
+export function matchAccessibleName(
+  node: ReactTestInstance,
+  expectedName?: TextMatch,
+  normalizer?: TextMatchOptions['normalizer'],
+  exact?: TextMatchOptions['exact']
+): boolean {
+  const accessibleName = getAccessibleName(node);
+
+  if (expectedName) {
+    return matches(expectedName, accessibleName, normalizer, exact);
+  }
+
+  return !!accessibleName;
+}
diff --git a/src/matchers/__tests__/to-have-accessible-name.test.tsx b/src/matchers/__tests__/to-have-accessible-name.test.tsx
new file mode 100644
index 000000000..482279604
--- /dev/null
+++ b/src/matchers/__tests__/to-have-accessible-name.test.tsx
@@ -0,0 +1,111 @@
+import * as React from 'react';
+import { View, Text, TextInput } from 'react-native';
+import { render, screen } from '../..';
+import '../extend-expect';
+
+test('toHaveAccessibleName() on view with accessibilityLabel prop', () => {
+  render(<View testID="accessibility-label" accessibilityLabel="Test Label" />);
+  const element = screen.getByTestId('accessibility-label');
+  expect(element).toHaveAccessibleName('Test Label');
+});
+
+test('toHaveAccessibleName() on view with aria-label prop', () => {
+  render(<View testID="aria-label" aria-label="Aria Test Label" />);
+  const element = screen.getByTestId('aria-label');
+  expect(element).toHaveAccessibleName('Aria Test Label');
+});
+
+test('toHaveAccessibleName() on view with accessibilityLabel prop with no expectedName', () => {
+  render(<View testID="no-expectName-label" accessibilityLabel="Test Label" />);
+  const element = screen.getByTestId('no-expectName-label');
+  expect(element).toHaveAccessibleName();
+});
+
+test('toHaveAccessibleName() on view with no accessibility props', () => {
+  render(<Text testID="accessibility-label">Text</Text>);
+  const element = screen.getByTestId('accessibility-label');
+  expect(element).toHaveAccessibleName('Text');
+});
+
+test('toHaveAccessibleName() on view with that does not have the expected accessible name', () => {
+  render(<View testID="wrong-label" accessibilityLabel="The actual label" />);
+  const element = screen.getByTestId('wrong-label');
+  expect(() => expect(element).toHaveAccessibleName('Not the label'))
+    .toThrowErrorMatchingInlineSnapshot(`
+  "expect(element).toHaveAccessibleName()
+
+  Expected element to have accessible name:
+    Not the label
+  Received:
+    The actual label"
+`);
+});
+
+test('toHaveAccessibleName() on view that doesnt have accessible name defined', () => {
+  render(<View testID="no-accessibile-name" />);
+  const element = screen.getByTestId('no-accessibile-name');
+
+  expect(() => expect(element).toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(element).toHaveAccessibleName()
+
+    Expected element to have accessible name:
+
+    Received:
+      undefined"
+  `);
+});
+
+it('toHaveAccessibleName() on a non-host element', () => {
+  const nonElement = 'This is not a ReactTestInstance';
+  expect(() => expect(nonElement).toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(received).toHaveAccessibleName()
+
+    received value must be a host element.
+    Received has type:  string
+    Received has value: "This is not a ReactTestInstance""
+  `);
+});
+
+test('toHaveAccessibleName() on view with accessibilityLabelledBy prop', async () => {
+  render(
+    <View>
+      <Text nativeID="formLabel">Accessibility LabelledBy</Text>
+      <TextInput
+        testID="accessibility-labelledby"
+        accessibilityLabelledBy="formLabel"
+      />
+    </View>
+  );
+
+  const element = screen.getByTestId('accessibility-labelledby');
+  expect(element).toHaveAccessibleName('Accessibility LabelledBy');
+});
+
+test('toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
+  render(
+    <View>
+      <Text nativeID="formLabel">Aria LabelledBy</Text>
+      <TextInput testID="aria-labelledby" aria-labelledby="formLabel" />
+    </View>
+  );
+
+  const element = screen.getByTestId('aria-labelledby');
+  expect(element).toHaveAccessibleName('Aria LabelledBy');
+});
+
+//TODO: This fails as expected as I am unsure on how to extract the Text from the nested Element
+test('getByLabelText supports nested aria-labelledby', async () => {
+  const screen = render(
+    <>
+      <View nativeID="label">
+        <Text>Nested Aria LabelledBy</Text>
+      </View>
+      <TextInput testID="text-input" aria-labelledby="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).toHaveAccessibleName('Nested Aria LabelledBy');
+});
diff --git a/src/matchers/extend-expect.d.ts b/src/matchers/extend-expect.d.ts
index 55cb2df53..c7129df45 100644
--- a/src/matchers/extend-expect.d.ts
+++ b/src/matchers/extend-expect.d.ts
@@ -22,6 +22,7 @@ export interface JestNativeMatchers<R> {
   toHaveProp(name: string, expectedValue?: unknown): R;
   toHaveStyle(style: StyleProp<Style>): R;
   toHaveTextContent(expectedText: TextMatch, options?: TextMatchOptions): R;
+  toHaveAccessibleName(expectedName?: TextMatch, options?: TextMatchOptions): R;
 }
 
 // Implicit Jest global `expect`.
diff --git a/src/matchers/extend-expect.ts b/src/matchers/extend-expect.ts
index 983b83124..3f380ab68 100644
--- a/src/matchers/extend-expect.ts
+++ b/src/matchers/extend-expect.ts
@@ -16,6 +16,7 @@ import { toHaveDisplayValue } from './to-have-display-value';
 import { toHaveProp } from './to-have-prop';
 import { toHaveStyle } from './to-have-style';
 import { toHaveTextContent } from './to-have-text-content';
+import { toHaveAccessibleName } from './to-have-accessible-name';
 
 expect.extend({
   toBeOnTheScreen,
@@ -35,4 +36,5 @@ expect.extend({
   toHaveProp,
   toHaveStyle,
   toHaveTextContent,
+  toHaveAccessibleName,
 });
diff --git a/src/matchers/index.ts b/src/matchers/index.ts
index 2138fabce..3360db2ee 100644
--- a/src/matchers/index.ts
+++ b/src/matchers/index.ts
@@ -14,3 +14,4 @@ export { toHaveDisplayValue } from './to-have-display-value';
 export { toHaveProp } from './to-have-prop';
 export { toHaveStyle } from './to-have-style';
 export { toHaveTextContent } from './to-have-text-content';
+export { toHaveAccessibleName } from './to-have-accessible-name';
diff --git a/src/matchers/to-have-accessible-name.tsx b/src/matchers/to-have-accessible-name.tsx
new file mode 100644
index 000000000..5e6a31b06
--- /dev/null
+++ b/src/matchers/to-have-accessible-name.tsx
@@ -0,0 +1,43 @@
+import type { ReactTestInstance } from 'react-test-renderer';
+import { matcherHint } from 'jest-matcher-utils';
+import { matchAccessibleName } from '../helpers/matchers/accessibilityName';
+import { getAccessibleName } from '../helpers/accessiblity';
+import { TextMatch, TextMatchOptions } from '../matches';
+import { checkHostElement, formatMessage } from './utils';
+
+export function toHaveAccessibleName(
+  this: jest.MatcherContext,
+  element: ReactTestInstance,
+  expectedName?: TextMatch,
+  options?: TextMatchOptions
+) {
+  checkHostElement(element, toHaveAccessibleName, this);
+
+  const receivedName = getAccessibleName(element);
+
+  return {
+    pass: matchAccessibleName(
+      element,
+      expectedName,
+      options?.normalizer,
+      options?.exact
+    ),
+    message: () => {
+      return [
+        formatMessage(
+          matcherHint(
+            `${this.isNot ? '.not' : ''}.toHaveAccessibleName`,
+            'element',
+            ''
+          ),
+          `Expected element ${
+            this.isNot ? 'not to' : 'to'
+          } have accessible name`,
+          `${expectedName ? expectedName : ''}`,
+          'Received',
+          receivedName
+        ),
+      ].join('\n');
+    },
+  };
+}

From 4445c3376209b093e0203fba8e34a4c45647a2e6 Mon Sep 17 00:00:00 2001
From: anishapm <anishamalde95@gmail.com>
Date: Thu, 5 Oct 2023 12:45:09 +0100
Subject: [PATCH 2/7] feat: toHaveAccessibleName matcher

---
 src/helpers/accessiblity.ts                   |  33 +----
 src/helpers/matchers/accessibilityName.ts     |   2 +-
 .../to-have-accessible-name.test.tsx          | 137 +++++++++++++++++-
 src/matchers/extend-expect.d.ts               |   2 +-
 src/matchers/extend-expect.ts                 |   4 +-
 src/matchers/index.ts                         |   2 +-
 src/matchers/to-have-accessible-name.tsx      |  27 +++-
 7 files changed, 167 insertions(+), 40 deletions(-)

diff --git a/src/helpers/accessiblity.ts b/src/helpers/accessiblity.ts
index b64644a0c..7419d3356 100644
--- a/src/helpers/accessiblity.ts
+++ b/src/helpers/accessiblity.ts
@@ -4,7 +4,7 @@ import {
   StyleSheet,
 } from 'react-native';
 import { ReactTestInstance } from 'react-test-renderer';
-import { getHostSiblings, getHostParent } from './component-tree';
+import { getHostSiblings } from './component-tree';
 import { getHostComponentNames } from './host-component-names';
 
 type IsInaccessibleOptions = {
@@ -233,34 +233,3 @@ export function isElementSelected(
   const { accessibilityState, 'aria-selected': ariaSelected } = element.props;
   return ariaSelected ?? accessibilityState?.selected ?? false;
 }
-
-export function getAccessibleName(
-  element: ReactTestInstance
-): string | undefined {
-  const labelTextFromLabel = getAccessibilityLabel(element);
-  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
-
-  if (labelTextFromLabelledBy) {
-    const parentElement = getHostParent(element);
-
-    if (parentElement) {
-      const labelElement = parentElement.findByProps({
-        nativeID: labelTextFromLabelledBy,
-      });
-
-      if (labelElement) {
-        // Extract and return the text content of the label element
-        const label = labelElement.props.children;
-        return label;
-      }
-    }
-  }
-
-  if (labelTextFromLabel) {
-    return labelTextFromLabel;
-  }
-
-  const ownText = element?.children?.join(' ');
-
-  return ownText || undefined;
-}
diff --git a/src/helpers/matchers/accessibilityName.ts b/src/helpers/matchers/accessibilityName.ts
index e90d2bcca..5bcd31846 100644
--- a/src/helpers/matchers/accessibilityName.ts
+++ b/src/helpers/matchers/accessibilityName.ts
@@ -1,5 +1,5 @@
 import { ReactTestInstance } from 'react-test-renderer';
-import { getAccessibleName } from '../accessiblity';
+import { getAccessibleName } from '../../matchers/to-have-accessible-name';
 import { TextMatchOptions, matches, TextMatch } from '../../matches';
 
 export function matchAccessibleName(
diff --git a/src/matchers/__tests__/to-have-accessible-name.test.tsx b/src/matchers/__tests__/to-have-accessible-name.test.tsx
index 482279604..93040617b 100644
--- a/src/matchers/__tests__/to-have-accessible-name.test.tsx
+++ b/src/matchers/__tests__/to-have-accessible-name.test.tsx
@@ -9,12 +9,24 @@ test('toHaveAccessibleName() on view with accessibilityLabel prop', () => {
   expect(element).toHaveAccessibleName('Test Label');
 });
 
+test('not.toHaveAccessibleName() on view with accessibilityLabel prop', () => {
+  render(<View testID="accessibility-label" accessibilityLabel="Test Label" />);
+  const element = screen.getByTestId('accessibility-label');
+  expect(element).not.toHaveAccessibleName('Not Test Label');
+});
+
 test('toHaveAccessibleName() on view with aria-label prop', () => {
   render(<View testID="aria-label" aria-label="Aria Test Label" />);
   const element = screen.getByTestId('aria-label');
   expect(element).toHaveAccessibleName('Aria Test Label');
 });
 
+test('not.toHaveAccessibleName() on view with aria-label prop', () => {
+  render(<View testID="aria-label" aria-label="Aria Test Label" />);
+  const element = screen.getByTestId('aria-label');
+  expect(element).not.toHaveAccessibleName('Not Aria Test Label');
+});
+
 test('toHaveAccessibleName() on view with accessibilityLabel prop with no expectedName', () => {
   render(<View testID="no-expectName-label" accessibilityLabel="Test Label" />);
   const element = screen.getByTestId('no-expectName-label');
@@ -27,6 +39,12 @@ test('toHaveAccessibleName() on view with no accessibility props', () => {
   expect(element).toHaveAccessibleName('Text');
 });
 
+test('not.toHaveAccessibleName() on view with no accessibility props', () => {
+  render(<Text testID="accessibility-label">Text</Text>);
+  const element = screen.getByTestId('accessibility-label');
+  expect(element).not.toHaveAccessibleName('Not the expected Text');
+});
+
 test('toHaveAccessibleName() on view with that does not have the expected accessible name', () => {
   render(<View testID="wrong-label" accessibilityLabel="The actual label" />);
   const element = screen.getByTestId('wrong-label');
@@ -56,6 +74,13 @@ test('toHaveAccessibleName() on view that doesnt have accessible name defined',
   `);
 });
 
+test('not.toHaveAccessibleName() on view that doesnt have accessible name defined', () => {
+  render(<View testID="no-accessibile-name" />);
+  const element = screen.getByTestId('no-accessibile-name');
+
+  expect(element).not.toHaveAccessibleName();
+});
+
 it('toHaveAccessibleName() on a non-host element', () => {
   const nonElement = 'This is not a ReactTestInstance';
   expect(() => expect(nonElement).toHaveAccessibleName())
@@ -68,6 +93,18 @@ it('toHaveAccessibleName() on a non-host element', () => {
   `);
 });
 
+it('not.toHaveAccessibleName() on a non-host element', () => {
+  const nonElement = 'This is not a ReactTestInstance';
+  expect(() => expect(nonElement).not.toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(received).not.toHaveAccessibleName()
+
+    received value must be a host element.
+    Received has type:  string
+    Received has value: "This is not a ReactTestInstance""
+  `);
+});
+
 test('toHaveAccessibleName() on view with accessibilityLabelledBy prop', async () => {
   render(
     <View>
@@ -83,6 +120,63 @@ test('toHaveAccessibleName() on view with accessibilityLabelledBy prop', async (
   expect(element).toHaveAccessibleName('Accessibility LabelledBy');
 });
 
+test('not.toHaveAccessibleName() on view with accessibilityLabelledBy prop', async () => {
+  render(
+    <View>
+      <Text nativeID="formLabel">Accessibility LabelledBy</Text>
+      <TextInput
+        testID="accessibility-labelledby"
+        accessibilityLabelledBy="formLabel"
+      />
+    </View>
+  );
+
+  const element = screen.getByTestId('accessibility-labelledby');
+  expect(element).not.toHaveAccessibleName('Not Accessibility LabelledBy');
+});
+
+test('getByLabelText supports nested accessibilityLabelledBy', async () => {
+  render(
+    <>
+      <View nativeID="label">
+        <Text>Nested Accessibility LabelledBy</Text>
+      </View>
+      <TextInput testID="text-input" accessibilityLabelledBy="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).toHaveAccessibleName('Nested Accessibility LabelledBy');
+});
+
+test('not.toHaveAccessibleName() on view with nested accessibilityLabelledBy', async () => {
+  render(
+    <>
+      <View nativeID="label">
+        <Text>Nested Aria LabelledBy</Text>
+      </View>
+      <TextInput testID="text-input" accessibilityLabelledBy="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).not.toHaveAccessibleName('Not Nested Aria LabelledBy');
+});
+
+test('not.toHaveAccessibleName() on view with nested accessibilityLabelledBy with no text', async () => {
+  render(
+    <>
+      <View nativeID="label">
+        <View />
+      </View>
+      <TextInput testID="text-input" accessibilityLabelledBy="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).not.toHaveAccessibleName();
+});
+
 test('toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
   render(
     <View>
@@ -95,9 +189,20 @@ test('toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
   expect(element).toHaveAccessibleName('Aria LabelledBy');
 });
 
-//TODO: This fails as expected as I am unsure on how to extract the Text from the nested Element
+test('not.toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
+  render(
+    <View>
+      <Text nativeID="formLabel">Aria LabelledBy</Text>
+      <TextInput testID="aria-labelledby" aria-labelledby="formLabel" />
+    </View>
+  );
+
+  const element = screen.getByTestId('aria-labelledby');
+  expect(element).not.toHaveAccessibleName('Not Aria LabelledBy');
+});
+
 test('getByLabelText supports nested aria-labelledby', async () => {
-  const screen = render(
+  render(
     <>
       <View nativeID="label">
         <Text>Nested Aria LabelledBy</Text>
@@ -109,3 +214,31 @@ test('getByLabelText supports nested aria-labelledby', async () => {
   const element = screen.getByTestId('text-input');
   expect(element).toHaveAccessibleName('Nested Aria LabelledBy');
 });
+
+test('not.toHaveAccessibleName() on view with nested aria-labelledby', async () => {
+  render(
+    <>
+      <View nativeID="label">
+        <Text>Nested Aria LabelledBy</Text>
+      </View>
+      <TextInput testID="text-input" aria-labelledby="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).not.toHaveAccessibleName('Not Nested Aria LabelledBy');
+});
+
+test('not.toHaveAccessibleName() on view with nested aria-labelledby with no text', async () => {
+  render(
+    <>
+      <View nativeID="label">
+        <View />
+      </View>
+      <TextInput testID="text-input" aria-labelledby="label" />
+    </>
+  );
+
+  const element = screen.getByTestId('text-input');
+  expect(element).not.toHaveAccessibleName();
+});
diff --git a/src/matchers/extend-expect.d.ts b/src/matchers/extend-expect.d.ts
index c7129df45..7d76db0c1 100644
--- a/src/matchers/extend-expect.d.ts
+++ b/src/matchers/extend-expect.d.ts
@@ -18,11 +18,11 @@ export interface JestNativeMatchers<R> {
   toBeVisible(): R;
   toContainElement(element: ReactTestInstance | null): R;
   toHaveAccessibilityValue(expectedValue: AccessibilityValueMatcher): R;
+  toHaveAccessibleName(expectedName?: TextMatch, options?: TextMatchOptions): R;
   toHaveDisplayValue(expectedValue: TextMatch, options?: TextMatchOptions): R;
   toHaveProp(name: string, expectedValue?: unknown): R;
   toHaveStyle(style: StyleProp<Style>): R;
   toHaveTextContent(expectedText: TextMatch, options?: TextMatchOptions): R;
-  toHaveAccessibleName(expectedName?: TextMatch, options?: TextMatchOptions): R;
 }
 
 // Implicit Jest global `expect`.
diff --git a/src/matchers/extend-expect.ts b/src/matchers/extend-expect.ts
index 3f380ab68..e0a1dc2a3 100644
--- a/src/matchers/extend-expect.ts
+++ b/src/matchers/extend-expect.ts
@@ -12,11 +12,11 @@ import { toBeSelected } from './to-be-selected';
 import { toBeVisible } from './to-be-visible';
 import { toContainElement } from './to-contain-element';
 import { toHaveAccessibilityValue } from './to-have-accessibility-value';
+import { toHaveAccessibleName } from './to-have-accessible-name';
 import { toHaveDisplayValue } from './to-have-display-value';
 import { toHaveProp } from './to-have-prop';
 import { toHaveStyle } from './to-have-style';
 import { toHaveTextContent } from './to-have-text-content';
-import { toHaveAccessibleName } from './to-have-accessible-name';
 
 expect.extend({
   toBeOnTheScreen,
@@ -32,9 +32,9 @@ expect.extend({
   toBeVisible,
   toContainElement,
   toHaveAccessibilityValue,
+  toHaveAccessibleName,
   toHaveDisplayValue,
   toHaveProp,
   toHaveStyle,
   toHaveTextContent,
-  toHaveAccessibleName,
 });
diff --git a/src/matchers/index.ts b/src/matchers/index.ts
index 3360db2ee..23af0223c 100644
--- a/src/matchers/index.ts
+++ b/src/matchers/index.ts
@@ -10,8 +10,8 @@ export { toBeSelected } from './to-be-selected';
 export { toBeVisible } from './to-be-visible';
 export { toContainElement } from './to-contain-element';
 export { toHaveAccessibilityValue } from './to-have-accessibility-value';
+export { toHaveAccessibleName } from './to-have-accessible-name';
 export { toHaveDisplayValue } from './to-have-display-value';
 export { toHaveProp } from './to-have-prop';
 export { toHaveStyle } from './to-have-style';
 export { toHaveTextContent } from './to-have-text-content';
-export { toHaveAccessibleName } from './to-have-accessible-name';
diff --git a/src/matchers/to-have-accessible-name.tsx b/src/matchers/to-have-accessible-name.tsx
index 5e6a31b06..8c6a51ca3 100644
--- a/src/matchers/to-have-accessible-name.tsx
+++ b/src/matchers/to-have-accessible-name.tsx
@@ -1,10 +1,35 @@
 import type { ReactTestInstance } from 'react-test-renderer';
 import { matcherHint } from 'jest-matcher-utils';
 import { matchAccessibleName } from '../helpers/matchers/accessibilityName';
-import { getAccessibleName } from '../helpers/accessiblity';
+import {
+  getAccessibilityLabel,
+  getAccessibilityLabelledBy,
+} from '../helpers/accessiblity';
 import { TextMatch, TextMatchOptions } from '../matches';
+import { getTextContent } from '../helpers/text-content';
+import { getUnsafeRootElement } from '../helpers/component-tree';
 import { checkHostElement, formatMessage } from './utils';
 
+export function getAccessibleName(
+  element: ReactTestInstance
+): string | undefined {
+  const labelTextFromLabel = getAccessibilityLabel(element);
+  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
+  const rootElement = getUnsafeRootElement(element);
+
+  const labelledByElement = labelTextFromLabelledBy
+    ? rootElement?.findByProps({
+        nativeID: labelTextFromLabelledBy,
+      })
+    : undefined;
+
+  const nameFromLabel = labelTextFromLabelledBy
+    ? labelledByElement && getTextContent(labelledByElement)
+    : labelTextFromLabel;
+
+  return nameFromLabel || getTextContent(element) || undefined;
+}
+
 export function toHaveAccessibleName(
   this: jest.MatcherContext,
   element: ReactTestInstance,

From 6cd87343766efe6357cc72bd55926d605dda0252 Mon Sep 17 00:00:00 2001
From: anishapm <anishamalde95@gmail.com>
Date: Thu, 5 Oct 2023 12:53:02 +0100
Subject: [PATCH 3/7] feat: toHaveAccessibleName matcher

---
 src/helpers/accessiblity.ts               | 23 +++++++++++++-
 src/helpers/matchers/accessibilityName.ts | 18 -----------
 src/matchers/to-have-accessible-name.tsx  | 37 ++++++++---------------
 3 files changed, 35 insertions(+), 43 deletions(-)
 delete mode 100644 src/helpers/matchers/accessibilityName.ts

diff --git a/src/helpers/accessiblity.ts b/src/helpers/accessiblity.ts
index 7419d3356..fa444a7ac 100644
--- a/src/helpers/accessiblity.ts
+++ b/src/helpers/accessiblity.ts
@@ -4,7 +4,8 @@ import {
   StyleSheet,
 } from 'react-native';
 import { ReactTestInstance } from 'react-test-renderer';
-import { getHostSiblings } from './component-tree';
+import { getTextContent } from './text-content';
+import { getHostSiblings, getUnsafeRootElement } from './component-tree';
 import { getHostComponentNames } from './host-component-names';
 
 type IsInaccessibleOptions = {
@@ -233,3 +234,23 @@ export function isElementSelected(
   const { accessibilityState, 'aria-selected': ariaSelected } = element.props;
   return ariaSelected ?? accessibilityState?.selected ?? false;
 }
+
+export function getAccessibleName(
+  element: ReactTestInstance
+): string | undefined {
+  const labelTextFromLabel = getAccessibilityLabel(element);
+  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
+  const rootElement = getUnsafeRootElement(element);
+
+  const labelledByElement = labelTextFromLabelledBy
+    ? rootElement?.findByProps({
+        nativeID: labelTextFromLabelledBy,
+      })
+    : undefined;
+
+  const nameFromLabel = labelTextFromLabelledBy
+    ? labelledByElement && getTextContent(labelledByElement)
+    : labelTextFromLabel;
+
+  return nameFromLabel || getTextContent(element) || undefined;
+}
diff --git a/src/helpers/matchers/accessibilityName.ts b/src/helpers/matchers/accessibilityName.ts
deleted file mode 100644
index 5bcd31846..000000000
--- a/src/helpers/matchers/accessibilityName.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import { ReactTestInstance } from 'react-test-renderer';
-import { getAccessibleName } from '../../matchers/to-have-accessible-name';
-import { TextMatchOptions, matches, TextMatch } from '../../matches';
-
-export function matchAccessibleName(
-  node: ReactTestInstance,
-  expectedName?: TextMatch,
-  normalizer?: TextMatchOptions['normalizer'],
-  exact?: TextMatchOptions['exact']
-): boolean {
-  const accessibleName = getAccessibleName(node);
-
-  if (expectedName) {
-    return matches(expectedName, accessibleName, normalizer, exact);
-  }
-
-  return !!accessibleName;
-}
diff --git a/src/matchers/to-have-accessible-name.tsx b/src/matchers/to-have-accessible-name.tsx
index 8c6a51ca3..3fe5d6447 100644
--- a/src/matchers/to-have-accessible-name.tsx
+++ b/src/matchers/to-have-accessible-name.tsx
@@ -1,33 +1,22 @@
 import type { ReactTestInstance } from 'react-test-renderer';
 import { matcherHint } from 'jest-matcher-utils';
-import { matchAccessibleName } from '../helpers/matchers/accessibilityName';
-import {
-  getAccessibilityLabel,
-  getAccessibilityLabelledBy,
-} from '../helpers/accessiblity';
-import { TextMatch, TextMatchOptions } from '../matches';
-import { getTextContent } from '../helpers/text-content';
-import { getUnsafeRootElement } from '../helpers/component-tree';
+import { TextMatch, TextMatchOptions, matches } from '../matches';
+import { getAccessibleName } from '../helpers/accessiblity';
 import { checkHostElement, formatMessage } from './utils';
 
-export function getAccessibleName(
-  element: ReactTestInstance
-): string | undefined {
-  const labelTextFromLabel = getAccessibilityLabel(element);
-  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
-  const rootElement = getUnsafeRootElement(element);
-
-  const labelledByElement = labelTextFromLabelledBy
-    ? rootElement?.findByProps({
-        nativeID: labelTextFromLabelledBy,
-      })
-    : undefined;
+export function matchAccessibleName(
+  node: ReactTestInstance,
+  expectedName?: TextMatch,
+  normalizer?: TextMatchOptions['normalizer'],
+  exact?: TextMatchOptions['exact']
+): boolean {
+  const accessibleName = getAccessibleName(node);
 
-  const nameFromLabel = labelTextFromLabelledBy
-    ? labelledByElement && getTextContent(labelledByElement)
-    : labelTextFromLabel;
+  if (expectedName) {
+    return matches(expectedName, accessibleName, normalizer, exact);
+  }
 
-  return nameFromLabel || getTextContent(element) || undefined;
+  return !!accessibleName;
 }
 
 export function toHaveAccessibleName(

From fca347eaef9a2a534092b10870bf68568c9adcff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maciej=20Jastrze=CC=A8bski?= <mdjastrzebski@gmail.com>
Date: Tue, 31 Oct 2023 23:06:59 +0100
Subject: [PATCH 4/7] refactor: check logic

---
 src/helpers/accessiblity.ts                   | 26 ++++++++--------
 .../to-have-accessible-name.test.tsx          | 30 +++++++++----------
 src/matchers/to-have-accessible-name.tsx      | 27 ++++++++++++-----
 src/matchers/utils.tsx                        |  2 +-
 4 files changed, 48 insertions(+), 37 deletions(-)

diff --git a/src/helpers/accessiblity.ts b/src/helpers/accessiblity.ts
index fa444a7ac..aed19ced6 100644
--- a/src/helpers/accessiblity.ts
+++ b/src/helpers/accessiblity.ts
@@ -238,19 +238,19 @@ export function isElementSelected(
 export function getAccessibleName(
   element: ReactTestInstance
 ): string | undefined {
-  const labelTextFromLabel = getAccessibilityLabel(element);
-  const labelTextFromLabelledBy = getAccessibilityLabelledBy(element);
-  const rootElement = getUnsafeRootElement(element);
-
-  const labelledByElement = labelTextFromLabelledBy
-    ? rootElement?.findByProps({
-        nativeID: labelTextFromLabelledBy,
-      })
-    : undefined;
+  const label = getAccessibilityLabel(element);
+  if (label) {
+    return label;
+  }
 
-  const nameFromLabel = labelTextFromLabelledBy
-    ? labelledByElement && getTextContent(labelledByElement)
-    : labelTextFromLabel;
+  const labelElementId = getAccessibilityLabelledBy(element);
+  if (labelElementId) {
+    const rootElement = getUnsafeRootElement(element);
+    const labelElement = rootElement?.findByProps({ nativeID: labelElementId });
+    if (labelElement) {
+      return getTextContent(labelElement);
+    }
+  }
 
-  return nameFromLabel || getTextContent(element) || undefined;
+  return getTextContent(element);
 }
diff --git a/src/matchers/__tests__/to-have-accessible-name.test.tsx b/src/matchers/__tests__/to-have-accessible-name.test.tsx
index 93040617b..c3ed54cb2 100644
--- a/src/matchers/__tests__/to-have-accessible-name.test.tsx
+++ b/src/matchers/__tests__/to-have-accessible-name.test.tsx
@@ -50,13 +50,13 @@ test('toHaveAccessibleName() on view with that does not have the expected access
   const element = screen.getByTestId('wrong-label');
   expect(() => expect(element).toHaveAccessibleName('Not the label'))
     .toThrowErrorMatchingInlineSnapshot(`
-  "expect(element).toHaveAccessibleName()
+    "expect(element).toHaveAccessibleName()
 
-  Expected element to have accessible name:
-    Not the label
-  Received:
-    The actual label"
-`);
+    Expected element to have accessible name:
+      Not the label
+    Received:
+      The actual label"
+  `);
 });
 
 test('toHaveAccessibleName() on view that doesnt have accessible name defined', () => {
@@ -68,9 +68,9 @@ test('toHaveAccessibleName() on view that doesnt have accessible name defined',
     "expect(element).toHaveAccessibleName()
 
     Expected element to have accessible name:
-
+      undefined
     Received:
-      undefined"
+    "
   `);
 });
 
@@ -189,30 +189,30 @@ test('toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
   expect(element).toHaveAccessibleName('Aria LabelledBy');
 });
 
-test('not.toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
+test('not.toHaveAccessibleName() on view with "aria-labelledby" prop', async () => {
   render(
     <View>
-      <Text nativeID="formLabel">Aria LabelledBy</Text>
-      <TextInput testID="aria-labelledby" aria-labelledby="formLabel" />
+      <Text nativeID="label">Aria Labelled By</Text>
+      <TextInput testID="aria-labelledby" aria-labelledby="label" />
     </View>
   );
 
   const element = screen.getByTestId('aria-labelledby');
-  expect(element).not.toHaveAccessibleName('Not Aria LabelledBy');
+  expect(element).not.toHaveAccessibleName('Not Aria Labelled By');
 });
 
-test('getByLabelText supports nested aria-labelledby', async () => {
+test('getByLabelText supports nested "aria-labelledby" prop', async () => {
   render(
     <>
       <View nativeID="label">
-        <Text>Nested Aria LabelledBy</Text>
+        <Text>Nested Aria Labelled By</Text>
       </View>
       <TextInput testID="text-input" aria-labelledby="label" />
     </>
   );
 
   const element = screen.getByTestId('text-input');
-  expect(element).toHaveAccessibleName('Nested Aria LabelledBy');
+  expect(element).toHaveAccessibleName('Nested Aria Labelled By');
 });
 
 test('not.toHaveAccessibleName() on view with nested aria-labelledby', async () => {
diff --git a/src/matchers/to-have-accessible-name.tsx b/src/matchers/to-have-accessible-name.tsx
index 3fe5d6447..0059dea3f 100644
--- a/src/matchers/to-have-accessible-name.tsx
+++ b/src/matchers/to-have-accessible-name.tsx
@@ -1,5 +1,5 @@
 import type { ReactTestInstance } from 'react-test-renderer';
-import { matcherHint } from 'jest-matcher-utils';
+import { matcherHint, stringify } from 'jest-matcher-utils';
 import { TextMatch, TextMatchOptions, matches } from '../matches';
 import { getAccessibleName } from '../helpers/accessiblity';
 import { checkHostElement, formatMessage } from './utils';
@@ -28,14 +28,25 @@ export function toHaveAccessibleName(
   checkHostElement(element, toHaveAccessibleName, this);
 
   const receivedName = getAccessibleName(element);
+  const missingExpectedValue = arguments.length === 1;
+
+  let pass = false;
+  if (missingExpectedValue) {
+    pass = receivedName !== '';
+  } else {
+    pass =
+      expectedName != null
+        ? matches(
+            expectedName,
+            receivedName,
+            options?.normalizer,
+            options?.exact
+          )
+        : false;
+  }
 
   return {
-    pass: matchAccessibleName(
-      element,
-      expectedName,
-      options?.normalizer,
-      options?.exact
-    ),
+    pass,
     message: () => {
       return [
         formatMessage(
@@ -47,7 +58,7 @@ export function toHaveAccessibleName(
           `Expected element ${
             this.isNot ? 'not to' : 'to'
           } have accessible name`,
-          `${expectedName ? expectedName : ''}`,
+          expectedName,
           'Received',
           receivedName
         ),
diff --git a/src/matchers/utils.tsx b/src/matchers/utils.tsx
index b79b65b3e..b6b7fa884 100644
--- a/src/matchers/utils.tsx
+++ b/src/matchers/utils.tsx
@@ -109,7 +109,7 @@ export function formatElementArray(elements: ReactTestInstance[]) {
 export function formatMessage(
   matcher: string,
   expectedLabel: string,
-  expectedValue: string | RegExp,
+  expectedValue: string | RegExp | null | undefined,
   receivedLabel: string,
   receivedValue: string | null | undefined
 ) {

From 9bba1b3599b79db6269e594e8e2b40bd8061d5bf Mon Sep 17 00:00:00 2001
From: Maciej Jastrzebski <mdjastrzebski@gmail.com>
Date: Wed, 8 Nov 2023 09:45:55 +0100
Subject: [PATCH 5/7] chore: fix lint

---
 src/matchers/to-have-accessible-name.tsx | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/matchers/to-have-accessible-name.tsx b/src/matchers/to-have-accessible-name.tsx
index 0059dea3f..9bf050f78 100644
--- a/src/matchers/to-have-accessible-name.tsx
+++ b/src/matchers/to-have-accessible-name.tsx
@@ -1,24 +1,9 @@
 import type { ReactTestInstance } from 'react-test-renderer';
-import { matcherHint, stringify } from 'jest-matcher-utils';
-import { TextMatch, TextMatchOptions, matches } from '../matches';
+import { matcherHint } from 'jest-matcher-utils';
 import { getAccessibleName } from '../helpers/accessiblity';
+import { TextMatch, TextMatchOptions, matches } from '../matches';
 import { checkHostElement, formatMessage } from './utils';
 
-export function matchAccessibleName(
-  node: ReactTestInstance,
-  expectedName?: TextMatch,
-  normalizer?: TextMatchOptions['normalizer'],
-  exact?: TextMatchOptions['exact']
-): boolean {
-  const accessibleName = getAccessibleName(node);
-
-  if (expectedName) {
-    return matches(expectedName, accessibleName, normalizer, exact);
-  }
-
-  return !!accessibleName;
-}
-
 export function toHaveAccessibleName(
   this: jest.MatcherContext,
   element: ReactTestInstance,

From 1f9f174bc037e7959339d37a51c1a347924c9a06 Mon Sep 17 00:00:00 2001
From: Maciej Jastrzebski <mdjastrzebski@gmail.com>
Date: Wed, 8 Nov 2023 10:24:58 +0100
Subject: [PATCH 6/7] refactor: tests

---
 .../to-have-accessible-name.test.tsx          | 264 +++++-------------
 1 file changed, 77 insertions(+), 187 deletions(-)

diff --git a/src/matchers/__tests__/to-have-accessible-name.test.tsx b/src/matchers/__tests__/to-have-accessible-name.test.tsx
index c3ed54cb2..d80a3366a 100644
--- a/src/matchers/__tests__/to-have-accessible-name.test.tsx
+++ b/src/matchers/__tests__/to-have-accessible-name.test.tsx
@@ -3,167 +3,49 @@ import { View, Text, TextInput } from 'react-native';
 import { render, screen } from '../..';
 import '../extend-expect';
 
-test('toHaveAccessibleName() on view with accessibilityLabel prop', () => {
-  render(<View testID="accessibility-label" accessibilityLabel="Test Label" />);
-  const element = screen.getByTestId('accessibility-label');
+test('toHaveAccessibleName() handles view with "accessibilityLabel" prop', () => {
+  render(<View testID="view" accessibilityLabel="Test Label" />);
+  const element = screen.getByTestId('view');
   expect(element).toHaveAccessibleName('Test Label');
+  expect(element).not.toHaveAccessibleName('Other Label');
 });
 
-test('not.toHaveAccessibleName() on view with accessibilityLabel prop', () => {
-  render(<View testID="accessibility-label" accessibilityLabel="Test Label" />);
-  const element = screen.getByTestId('accessibility-label');
-  expect(element).not.toHaveAccessibleName('Not Test Label');
-});
-
-test('toHaveAccessibleName() on view with aria-label prop', () => {
-  render(<View testID="aria-label" aria-label="Aria Test Label" />);
-  const element = screen.getByTestId('aria-label');
+test('toHaveAccessibleName() handles view with "aria-label" prop', () => {
+  render(<View testID="view" aria-label="Aria Test Label" />);
+  const element = screen.getByTestId('view');
   expect(element).toHaveAccessibleName('Aria Test Label');
+  expect(element).not.toHaveAccessibleName('Other Aria Label');
 });
 
-test('not.toHaveAccessibleName() on view with aria-label prop', () => {
-  render(<View testID="aria-label" aria-label="Aria Test Label" />);
-  const element = screen.getByTestId('aria-label');
-  expect(element).not.toHaveAccessibleName('Not Aria Test Label');
-});
-
-test('toHaveAccessibleName() on view with accessibilityLabel prop with no expectedName', () => {
-  render(<View testID="no-expectName-label" accessibilityLabel="Test Label" />);
-  const element = screen.getByTestId('no-expectName-label');
-  expect(element).toHaveAccessibleName();
-});
-
-test('toHaveAccessibleName() on view with no accessibility props', () => {
-  render(<Text testID="accessibility-label">Text</Text>);
-  const element = screen.getByTestId('accessibility-label');
-  expect(element).toHaveAccessibleName('Text');
-});
-
-test('not.toHaveAccessibleName() on view with no accessibility props', () => {
-  render(<Text testID="accessibility-label">Text</Text>);
-  const element = screen.getByTestId('accessibility-label');
-  expect(element).not.toHaveAccessibleName('Not the expected Text');
-});
-
-test('toHaveAccessibleName() on view with that does not have the expected accessible name', () => {
-  render(<View testID="wrong-label" accessibilityLabel="The actual label" />);
-  const element = screen.getByTestId('wrong-label');
-  expect(() => expect(element).toHaveAccessibleName('Not the label'))
-    .toThrowErrorMatchingInlineSnapshot(`
-    "expect(element).toHaveAccessibleName()
-
-    Expected element to have accessible name:
-      Not the label
-    Received:
-      The actual label"
-  `);
-});
-
-test('toHaveAccessibleName() on view that doesnt have accessible name defined', () => {
-  render(<View testID="no-accessibile-name" />);
-  const element = screen.getByTestId('no-accessibile-name');
-
-  expect(() => expect(element).toHaveAccessibleName())
-    .toThrowErrorMatchingInlineSnapshot(`
-    "expect(element).toHaveAccessibleName()
-
-    Expected element to have accessible name:
-      undefined
-    Received:
-    "
-  `);
-});
-
-test('not.toHaveAccessibleName() on view that doesnt have accessible name defined', () => {
-  render(<View testID="no-accessibile-name" />);
-  const element = screen.getByTestId('no-accessibile-name');
-
-  expect(element).not.toHaveAccessibleName();
-});
-
-it('toHaveAccessibleName() on a non-host element', () => {
-  const nonElement = 'This is not a ReactTestInstance';
-  expect(() => expect(nonElement).toHaveAccessibleName())
-    .toThrowErrorMatchingInlineSnapshot(`
-    "expect(received).toHaveAccessibleName()
-
-    received value must be a host element.
-    Received has type:  string
-    Received has value: "This is not a ReactTestInstance""
-  `);
-});
-
-it('not.toHaveAccessibleName() on a non-host element', () => {
-  const nonElement = 'This is not a ReactTestInstance';
-  expect(() => expect(nonElement).not.toHaveAccessibleName())
-    .toThrowErrorMatchingInlineSnapshot(`
-    "expect(received).not.toHaveAccessibleName()
-
-    received value must be a host element.
-    Received has type:  string
-    Received has value: "This is not a ReactTestInstance""
-  `);
-});
-
-test('toHaveAccessibleName() on view with accessibilityLabelledBy prop', async () => {
+test('toHaveAccessibleName() handles view with "accessibilityLabelledBy" prop', async () => {
   render(
     <View>
-      <Text nativeID="formLabel">Accessibility LabelledBy</Text>
-      <TextInput
-        testID="accessibility-labelledby"
-        accessibilityLabelledBy="formLabel"
-      />
+      <Text nativeID="label">External label</Text>
+      <TextInput testID="input" accessibilityLabelledBy="label" />
     </View>
   );
 
-  const element = screen.getByTestId('accessibility-labelledby');
-  expect(element).toHaveAccessibleName('Accessibility LabelledBy');
+  const element = screen.getByTestId('input');
+  expect(element).toHaveAccessibleName('External label');
+  expect(element).not.toHaveAccessibleName('Other label');
 });
 
-test('not.toHaveAccessibleName() on view with accessibilityLabelledBy prop', async () => {
-  render(
-    <View>
-      <Text nativeID="formLabel">Accessibility LabelledBy</Text>
-      <TextInput
-        testID="accessibility-labelledby"
-        accessibilityLabelledBy="formLabel"
-      />
-    </View>
-  );
-
-  const element = screen.getByTestId('accessibility-labelledby');
-  expect(element).not.toHaveAccessibleName('Not Accessibility LabelledBy');
-});
-
-test('getByLabelText supports nested accessibilityLabelledBy', async () => {
+test('toHaveAccessibleName() handles nested "accessibilityLabelledBy"', async () => {
   render(
     <>
       <View nativeID="label">
-        <Text>Nested Accessibility LabelledBy</Text>
+        <Text>External label</Text>
       </View>
-      <TextInput testID="text-input" accessibilityLabelledBy="label" />
+      <TextInput testID="input" accessibilityLabelledBy="label" />
     </>
   );
 
-  const element = screen.getByTestId('text-input');
-  expect(element).toHaveAccessibleName('Nested Accessibility LabelledBy');
+  const element = screen.getByTestId('input');
+  expect(element).toHaveAccessibleName('External label');
+  expect(element).not.toHaveAccessibleName('Other label');
 });
 
-test('not.toHaveAccessibleName() on view with nested accessibilityLabelledBy', async () => {
-  render(
-    <>
-      <View nativeID="label">
-        <Text>Nested Aria LabelledBy</Text>
-      </View>
-      <TextInput testID="text-input" accessibilityLabelledBy="label" />
-    </>
-  );
-
-  const element = screen.getByTestId('text-input');
-  expect(element).not.toHaveAccessibleName('Not Nested Aria LabelledBy');
-});
-
-test('not.toHaveAccessibleName() on view with nested accessibilityLabelledBy with no text', async () => {
+test('toHaveAccessibleName() handles view with nested "accessibilityLabelledBy" with no text', async () => {
   render(
     <>
       <View nativeID="label">
@@ -177,68 +59,76 @@ test('not.toHaveAccessibleName() on view with nested accessibilityLabelledBy wit
   expect(element).not.toHaveAccessibleName();
 });
 
-test('toHaveAccessibleName() on view with ariaLabelledBy prop', async () => {
+test('toHaveAccessibleName() handles view with "aria-labelledby" prop', async () => {
   render(
     <View>
-      <Text nativeID="formLabel">Aria LabelledBy</Text>
-      <TextInput testID="aria-labelledby" aria-labelledby="formLabel" />
+      <Text nativeID="label">External label</Text>
+      <TextInput testID="input" aria-labelledby="label" />
     </View>
   );
 
-  const element = screen.getByTestId('aria-labelledby');
-  expect(element).toHaveAccessibleName('Aria LabelledBy');
+  const element = screen.getByTestId('input');
+  expect(element).toHaveAccessibleName('External label');
+  expect(element).not.toHaveAccessibleName('Other label');
 });
 
-test('not.toHaveAccessibleName() on view with "aria-labelledby" prop', async () => {
-  render(
-    <View>
-      <Text nativeID="label">Aria Labelled By</Text>
-      <TextInput testID="aria-labelledby" aria-labelledby="label" />
-    </View>
-  );
-
-  const element = screen.getByTestId('aria-labelledby');
-  expect(element).not.toHaveAccessibleName('Not Aria Labelled By');
+test('toHaveAccessibleName() handles view with implicit accessible name', () => {
+  render(<Text testID="view">Text</Text>);
+  const element = screen.getByTestId('view');
+  expect(element).toHaveAccessibleName('Text');
+  expect(element).not.toHaveAccessibleName('Other text');
 });
 
-test('getByLabelText supports nested "aria-labelledby" prop', async () => {
-  render(
-    <>
-      <View nativeID="label">
-        <Text>Nested Aria Labelled By</Text>
-      </View>
-      <TextInput testID="text-input" aria-labelledby="label" />
-    </>
-  );
+test('toHaveAccessibleName() supports calling without expected name', () => {
+  render(<View testID="view" accessibilityLabel="Test Label" />);
+  const element = screen.getByTestId('view');
 
-  const element = screen.getByTestId('text-input');
-  expect(element).toHaveAccessibleName('Nested Aria Labelled By');
+  expect(element).toHaveAccessibleName();
+  expect(() => expect(element).not.toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(element).not.toHaveAccessibleName()
+
+    Expected element not to have accessible name:
+      undefined
+    Received:
+      Test Label"
+  `);
 });
 
-test('not.toHaveAccessibleName() on view with nested aria-labelledby', async () => {
-  render(
-    <>
-      <View nativeID="label">
-        <Text>Nested Aria LabelledBy</Text>
-      </View>
-      <TextInput testID="text-input" aria-labelledby="label" />
-    </>
-  );
+test('toHaveAccessibleName() handles a view without name when called without expected name', () => {
+  render(<View testID="view" />);
+  const element = screen.getByTestId('view');
 
-  const element = screen.getByTestId('text-input');
-  expect(element).not.toHaveAccessibleName('Not Nested Aria LabelledBy');
+  expect(element).not.toHaveAccessibleName();
+  expect(() => expect(element).toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(element).toHaveAccessibleName()
+
+    Expected element to have accessible name:
+      undefined
+    Received:
+    "
+  `);
 });
 
-test('not.toHaveAccessibleName() on view with nested aria-labelledby with no text', async () => {
-  render(
-    <>
-      <View nativeID="label">
-        <View />
-      </View>
-      <TextInput testID="text-input" aria-labelledby="label" />
-    </>
-  );
+it('toHaveAccessibleName() rejects non-host element', () => {
+  const nonElement = 'This is not a ReactTestInstance';
 
-  const element = screen.getByTestId('text-input');
-  expect(element).not.toHaveAccessibleName();
+  expect(() => expect(nonElement).toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(received).toHaveAccessibleName()
+
+    received value must be a host element.
+    Received has type:  string
+    Received has value: "This is not a ReactTestInstance""
+  `);
+
+  expect(() => expect(nonElement).not.toHaveAccessibleName())
+    .toThrowErrorMatchingInlineSnapshot(`
+    "expect(received).not.toHaveAccessibleName()
+
+    received value must be a host element.
+    Received has type:  string
+    Received has value: "This is not a ReactTestInstance""
+  `);
 });

From 7cbabbb5cb8f183b668b24881230e0d53b46fbc2 Mon Sep 17 00:00:00 2001
From: Maciej Jastrzebski <mdjastrzebski@gmail.com>
Date: Wed, 8 Nov 2023 10:36:16 +0100
Subject: [PATCH 7/7] chore: test tweaks

---
 .../__tests__/to-have-accessible-name.test.tsx   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/matchers/__tests__/to-have-accessible-name.test.tsx b/src/matchers/__tests__/to-have-accessible-name.test.tsx
index d80a3366a..1a355efc7 100644
--- a/src/matchers/__tests__/to-have-accessible-name.test.tsx
+++ b/src/matchers/__tests__/to-have-accessible-name.test.tsx
@@ -4,17 +4,17 @@ import { render, screen } from '../..';
 import '../extend-expect';
 
 test('toHaveAccessibleName() handles view with "accessibilityLabel" prop', () => {
-  render(<View testID="view" accessibilityLabel="Test Label" />);
+  render(<View testID="view" accessibilityLabel="Test label" />);
   const element = screen.getByTestId('view');
-  expect(element).toHaveAccessibleName('Test Label');
-  expect(element).not.toHaveAccessibleName('Other Label');
+  expect(element).toHaveAccessibleName('Test label');
+  expect(element).not.toHaveAccessibleName('Other label');
 });
 
 test('toHaveAccessibleName() handles view with "aria-label" prop', () => {
-  render(<View testID="view" aria-label="Aria Test Label" />);
+  render(<View testID="view" aria-label="Test label" />);
   const element = screen.getByTestId('view');
-  expect(element).toHaveAccessibleName('Aria Test Label');
-  expect(element).not.toHaveAccessibleName('Other Aria Label');
+  expect(element).toHaveAccessibleName('Test label');
+  expect(element).not.toHaveAccessibleName('Other label');
 });
 
 test('toHaveAccessibleName() handles view with "accessibilityLabelledBy" prop', async () => {
@@ -80,7 +80,7 @@ test('toHaveAccessibleName() handles view with implicit accessible name', () =>
 });
 
 test('toHaveAccessibleName() supports calling without expected name', () => {
-  render(<View testID="view" accessibilityLabel="Test Label" />);
+  render(<View testID="view" accessibilityLabel="Test label" />);
   const element = screen.getByTestId('view');
 
   expect(element).toHaveAccessibleName();
@@ -91,7 +91,7 @@ test('toHaveAccessibleName() supports calling without expected name', () => {
     Expected element not to have accessible name:
       undefined
     Received:
-      Test Label"
+      Test label"
   `);
 });