Skip to content

Remove use of getByTestID in documentation #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2020
Merged

Remove use of getByTestID in documentation #294

merged 2 commits into from
May 8, 2020

Conversation

cross19xx
Copy link
Contributor

@cross19xx cross19xx commented May 8, 2020

Summary

Fixes #283

All examples using getByTestID have been replaced with alternatives, such as getByText, or getByPlaceholder.

Tests that employed this have also been changed to use the alternatives

@cross19xx cross19xx requested review from thymikee and Esemesek May 8, 2020 12:35
@cross19xx cross19xx changed the title Remove use of getByTestID in documentations Remove use of getByTestID in documentation May 8, 2020
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely love it! 🥇

@thymikee thymikee merged commit 3e125d2 into master May 8, 2020
@thymikee thymikee deleted the issue_283 branch May 8, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use *ByTestId queries in documentation examples
2 participants