Remove deprecated func BuildWithSplitFunc from stanza/fileconsumer (open-telemetry#37723)

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

.chloggen/rm-dep-func.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: pkg/stanza
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Remove deprecated func BuildWithSplitFunc from stanza/fileconsumer
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [37723]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

pkg/stanza/decode/decode.go

@@ -16,7 +16,6 @@ import (
 )
 
 type Decoder struct {
-	encoding     encoding.Encoding
 	decoder      *encoding.Decoder
 	decodeBuffer []byte
 }
@@ -25,7 +24,6 @@ type Decoder struct {
 // Decoder is not thread-safe and must not be used in multiple goroutines.
 func New(enc encoding.Encoding) *Decoder {
 	return &Decoder{
-		encoding:     enc,
 		decoder:      enc.NewDecoder(),
 		decodeBuffer: make([]byte, 1<<12),
 	}

pkg/stanza/fileconsumer/config.go

@@ -95,11 +95,6 @@ type HeaderConfig struct {
 	MetadataOperators []operator.Config `mapstructure:"metadata_operators"`
 }
 
-// Deprecated [v0.97.0] Use Build and WithSplitFunc option instead
-func (c Config) BuildWithSplitFunc(set component.TelemetrySettings, emit emit.Callback, splitFunc bufio.SplitFunc) (*Manager, error) {
-	return c.Build(set, emit, WithSplitFunc(splitFunc))
-}
-
 func (c Config) Build(set component.TelemetrySettings, emit emit.Callback, opts ...Option) (*Manager, error) {
 	if err := c.validate(); err != nil {
 		return nil, err

pkg/stanza/fileconsumer/config_test.go

@@ -658,85 +658,6 @@ func TestBuild(t *testing.T) {
 	}
 }
 
-func TestBuildWithSplitFunc(t *testing.T) {
-	t.Parallel()
-
-	basicConfig := func() *Config {
-		cfg := NewConfig()
-		cfg.Include = []string{"/var/log/testpath.*"}
-		cfg.Exclude = []string{"/var/log/testpath.ex*"}
-		cfg.PollInterval = 10 * time.Millisecond
-		return cfg
-	}
-
-	cases := []struct {
-		name             string
-		modifyBaseConfig func(*Config)
-		errorRequirement require.ErrorAssertionFunc
-		validate         func(*testing.T, *Manager)
-	}{
-		{
-			"Basic",
-			func(_ *Config) {},
-			require.NoError,
-			func(t *testing.T, m *Manager) {
-				require.Equal(t, 10*time.Millisecond, m.pollInterval)
-			},
-		},
-		{
-			"BadIncludeGlob",
-			func(cfg *Config) {
-				cfg.Include = []string{"["}
-			},
-			require.Error,
-			nil,
-		},
-		{
-			"BadExcludeGlob",
-			func(cfg *Config) {
-				cfg.Include = []string{"["}
-			},
-			require.Error,
-			nil,
-		},
-		{
-			"InvalidEncoding",
-			func(cfg *Config) {
-				cfg.Encoding = "UTF-3233"
-			},
-			require.Error,
-			nil,
-		},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-			cfg := basicConfig()
-			tc.modifyBaseConfig(cfg)
-
-			splitNone := func(data []byte, atEOF bool) (advance int, token []byte, err error) {
-				if !atEOF {
-					return 0, nil, nil
-				}
-				if len(data) == 0 {
-					return 0, nil, nil
-				}
-				return len(data), data, nil
-			}
-
-			set := componenttest.NewNopTelemetrySettings()
-			input, err := cfg.BuildWithSplitFunc(set, emittest.Nop, splitNone)
-			tc.errorRequirement(t, err)
-			if err != nil {
-				return
-			}
-
-			tc.validate(t, input)
-		})
-	}
-}
-
 func TestBuildWithHeader(t *testing.T) {
 	basicConfig := func() *Config {
 		cfg := NewConfig()