From a433449edc8755be22a714c3d4fa67cf15cdde60 Mon Sep 17 00:00:00 2001 From: Raya Straus Date: Sun, 2 Jan 2022 13:52:00 +0200 Subject: [PATCH] Fix fromJson for quality action --- .../unit/fromJson/delivery.fromJson.test.ts | 66 +++++++++++++++++++ src/internal/internalConstants.ts | 6 ++ 2 files changed, 72 insertions(+) diff --git a/__TESTS__/unit/fromJson/delivery.fromJson.test.ts b/__TESTS__/unit/fromJson/delivery.fromJson.test.ts index d2a0eeb0..5056a903 100644 --- a/__TESTS__/unit/fromJson/delivery.fromJson.test.ts +++ b/__TESTS__/unit/fromJson/delivery.fromJson.test.ts @@ -90,6 +90,72 @@ describe('delivery.fromJson', () => { expect(transformation.toString()).toStrictEqual('q_auto:best'); }); + it('quality:auto:eco', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'autoEco' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_auto:eco'); + }); + + it('quality:auto:good', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'autoGood' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_auto:good'); + }); + + it('quality:auto:low', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'autoLow' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_auto:low'); + }); + + it('quality:jpegminiHigh', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'jpegminiHigh' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_jpegmini:1'); + }); + + it('quality:jpegminiMedium', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'jpegminiMedium' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_jpegmini:2'); + }); + + it('quality:jpegminiBest', () => { + const transformation = fromJson([ + { + actionType: 'quality', + level: 'jpegminiBest' + } + ]); + + expect(transformation.toString()).toStrictEqual('q_jpegmini:0'); + }); + it('chromaSubSampling', () => { const transformation = fromJson([ { diff --git a/src/internal/internalConstants.ts b/src/internal/internalConstants.ts index b38c3fc8..98cd10cb 100644 --- a/src/internal/internalConstants.ts +++ b/src/internal/internalConstants.ts @@ -110,6 +110,12 @@ export const ACTION_TYPE_TO_EFFECT_MODE_MAP: Record = { export const ACTION_TYPE_TO_QUALITY_MODE_MAP: Record = { autoBest: 'auto:best', + autoEco: 'auto:eco', + autoGood: 'auto:good', + autoLow: 'auto:low', + jpegminiHigh: 'jpegmini:1', + jpegminiMedium: 'jpegmini:2', + jpegminiBest: 'jpegmini:0' }; export const CHROMA_VALUE_TO_CHROMA_MODEL_ENUM: Record = {