Tune remediation points to match Classic

Changes include:
- Update PHP, Python, and JavaScript thresholds to match Classic
- Increase base_points for all four languages
- Add `points_per` value to each language
- change calculation formula from
    - `base_points * issue.mass_threshold`
  to
   - `base_points + overage * points_per`

Reference to rubric in classic for PHP, Ruby and JavaScript:
https://github.com/codeclimate/analyzer/blob/master/lib/quality/rubric.rb#L12c

And python:
https://github.com/codeclimate/analyzer/blob/master/lib/quality/profile.rb#L41

Author: ABaldwinHunter

lib/cc/engine/analyzers/analyzer_base.rb

@@ -11,6 +11,10 @@ class Base
           ::RubyParser::SyntaxError,
         ]
 
+        DEFAULT_MASS_THRESHOLD = 28
+        BASE_POINTS = 1_500_000
+        POINTS_PER = 50_000
+
         def initialize(engine_config:)
           @engine_config = engine_config
         end
@@ -37,6 +41,10 @@ def base_points
           self.class::BASE_POINTS
         end
 
+        def points_per
+          self.class::POINTS_PER
+        end
+
         private
 
         attr_reader :engine_config

lib/cc/engine/analyzers/javascript/main.rb

@@ -15,8 +15,6 @@ class Main < CC::Engine::Analyzers::Base
             "**/*.jsx"
           ]
           LANGUAGE = "javascript"
-          DEFAULT_MASS_THRESHOLD = 40
-          BASE_POINTS = 3000
 
           private
 

lib/cc/engine/analyzers/php/main.rb

@@ -14,8 +14,6 @@ class Main < CC::Engine::Analyzers::Base
             "**/*.inc",
             "**/*.module"
           ]
-          DEFAULT_MASS_THRESHOLD = 10
-          BASE_POINTS = 4_000
 
           private
 

lib/cc/engine/analyzers/python/main.rb

@@ -12,8 +12,6 @@ module Python
         class Main < CC::Engine::Analyzers::Base
           LANGUAGE = "python"
           DEFAULT_PATHS = ["**/*.py"]
-          DEFAULT_MASS_THRESHOLD = 40
-          BASE_POINTS = 1000
 
           private
 

lib/cc/engine/analyzers/reporter.rb

@@ -60,19 +60,15 @@ def flay
 
         attr_reader :engine_config, :language_strategy, :io
 
-        def mass_threshold
-          @mass_threshold ||= language_strategy.mass_threshold
-        end
-
         def new_violation(issue)
           hashes = flay.hashes[issue.structural_hash]
-          Violation.new(language_strategy.base_points, issue, hashes)
+          Violation.new(language_strategy, issue, hashes)
         end
 
         def flay_options
           {
             diff: false,
-            mass: mass_threshold,
+            mass: language_strategy.mass_threshold,
             summary: false,
             verbose: false,
             number: true,

lib/cc/engine/analyzers/ruby/main.rb

@@ -18,7 +18,7 @@ class Main < CC::Engine::Analyzers::Base
 
           ]
           DEFAULT_MASS_THRESHOLD = 18
-          BASE_POINTS = 10_000
+          POINTS_PER = 100_000
           TIMEOUT = 300
 
           private

lib/cc/engine/analyzers/violation.rb

@@ -8,8 +8,12 @@ module Analyzers
       class Violation
         attr_reader :issue
 
-        def initialize(base_points, issue, hashes)
-          @base_points = base_points
+        DEFAULT_POINTS = 1_500_000
+
+        def initialize(language, issue, hashes)
+          @base_points = language.base_points
+          @points_per = language.points_per
+          @threshold = language.mass_threshold
           @issue = issue
           @hashes = hashes
         end
@@ -32,9 +36,17 @@ def report_name
           "#{current_sexp.file}-#{current_sexp.line}"
         end
 
+        def calculate_points
+          if issue.mass >= threshold
+            base_points + (overage * points_per)
+          else
+            DEFAULT_POINTS
+          end
+        end
+
         private
 
-        attr_reader :base_points, :hashes
+        attr_reader :base_points, :points_per, :threshold, :hashes
 
         def current_sexp
           @location ||= sorted_hashes.first
@@ -56,8 +68,8 @@ def name
           end
         end
 
-        def calculate_points
-          base_points * issue.mass
+        def overage
+          issue.mass - threshold
         end
 
         def format_location

spec/cc/engine/analyzers/javascript/main_spec.rb

@@ -28,7 +28,7 @@
         "path" => "foo.js",
         "lines" => { "begin" => 1, "end" => 1 },
       })
-      expect(json["remediation_points"]).to eq(297000)
+      expect(json["remediation_points"]).to eq(6400000)
       expect(json["other_locations"]).to eq([
         {"path" => "foo.js", "lines" => { "begin" => 2, "end" => 2} },
         {"path" => "foo.js", "lines" => { "begin" => 3, "end" => 3} }

spec/cc/engine/analyzers/php/main_spec.rb

@@ -41,7 +41,7 @@
         "path" => "foo.php",
         "lines" => { "begin" => 2, "end" => 6 },
       })
-      expect(json["remediation_points"]).to eq(176000)
+      expect(json["remediation_points"]).to eq(3450000)
       expect(json["other_locations"]).to eq([
         {"path" => "foo.php", "lines" => { "begin" => 10, "end" => 14} },
       ])
@@ -61,7 +61,7 @@
   end
 
   def printed_issue
-    issue = {"type":"issue","check_name":"Identical code","description":"Similar code found in 1 other location","categories":["Duplication"],"location":{"path":"foo.php","lines":{"begin":2,"end":6}},"remediation_points":176000,"other_locations":[{"path":"foo.php","lines":{"begin":10,"end":14}}],"content":{"body": read_up}}
+    issue = {"type":"issue","check_name":"Identical code","description":"Similar code found in 1 other location","categories":["Duplication"],"location":{"path":"foo.php","lines":{"begin":2,"end":6}},"remediation_points":3450000,"other_locations":[{"path":"foo.php","lines":{"begin":10,"end":14}}],"content":{"body": read_up}}
     issue.to_json + "\0\n"
   end
 

spec/cc/engine/analyzers/python/main_spec.rb

@@ -28,7 +28,7 @@
         "path" => "foo.py",
         "lines" => { "begin" => 1, "end" => 1 },
       })
-      expect(json["remediation_points"]).to eq(54000)
+      expect(json["remediation_points"]).to eq(4000000)
       expect(json["other_locations"]).to eq([
         {"path" => "foo.py", "lines" => { "begin" => 2, "end" => 2} },
         {"path" => "foo.py", "lines" => { "begin" => 3, "end" => 3} }