fix specs. make calculate public

Author: ABaldwinHunter

lib/cc/engine/analyzers/violation.rb

@@ -36,6 +36,14 @@ def report_name
           "#{current_sexp.file}-#{current_sexp.line}"
         end
 
+        def calculate_points
+          if issue.mass >= threshold
+            base_points + (overage * points_per)
+          else
+            DEFAULT_POINTS
+          end
+        end
+
         private
 
         attr_reader :base_points, :points_per, :threshold, :hashes
@@ -60,14 +68,6 @@ def name
           end
         end
 
-        def calculate_points
-          if issue.mass >= threshold
-            base_points + (overage * points_per)
-          else
-            DEFAULT_POINTS
-          end
-        end
-
         def overage
           issue.mass - threshold
         end

spec/cc/engine/analyzers/reporter_spec.rb

@@ -8,6 +8,59 @@
 RSpec.describe CC::Engine::Analyzers::Violation, in_tmpdir: true do
   include AnalyzerSpecHelpers
 
+  describe "#calculate_points" do
+    context "when issue mass exceeds threshold" do
+      it "calculates mass overage points" do
+        base_points = 100
+        points_per = 50
+        threshold = 10
+        issue = double(:issue, mass: 15)
+        hashes = []
+
+        expected_points = base_points + points_per * (issue.mass - threshold)
+
+        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        points = violation.calculate_points
+
+        expect(points).to eq(expected_points)
+      end
+    end
+
+    context "when issue mass is less than threshold" do
+      it "uses default" do
+        base_points = 100
+        points_per = 50
+        threshold = 18
+        issue = double(:issue, mass: 15)
+        hashes = []
+
+        expected_points = CC::Engine::Analyzers::Violation::DEFAULT_POINTS
+
+        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        points = violation.calculate_points
+
+        expect(points).to eq(CC::Engine::Analyzers::Violation::DEFAULT_POINTS)
+      end
+    end
+
+    context "when issue mass equals threshold" do
+      it "calculates remediation points" do
+        base_points = 100
+        points_per = 50
+        threshold = 15
+        issue = double(:issue, mass: 15)
+        hashes = []
+
+        expected_points = base_points + points_per * (issue.mass - threshold)
+
+        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        points = violation.calculate_points
+
+        expect(points).to eq(expected_points)
+      end
+    end
+  end
+
   describe "#format" do
     it "returns correctly formatted issue" do
 

spec/cc/engine/analyzers/violation_spec.rb

@@ -21,18 +21,23 @@ def sample_flay_issue(
       mass = 99,
       locations = sample_locations
     )
-    flay = Flay::Item.new(structural_hash, name, bonus, mass, locations)
+
+    Flay::Item.new(structural_hash, name, bonus, mass, locations)
   end
 
   def sample_locations
     [
       sample_flay_location("./foo.js", 1, nil),
       sample_flay_location("./foo.js", 2, nil),
-      sample_flay_location("./foo.js", 3, nil),
+      sample_flay_location("./foo.js", 3, nil)
     ]
   end
 
   def sample_flay_location(file = "./foo.js", line = 1, fuzzy = nil)
     Flay::Location.new(file, line, fuzzy)
   end
+
+  def sample_hashes
+    [s(:ExpressionStatement, s(:expression, s(:CallExpression, s(:callee, s(:MemberExpression, s(:object, s(:Identifier, :console)), s(:property, s(:Identifier, :log)))), s(:arguments, s(:StringLiteral, :"hello JS!"))))), s(:ExpressionStatement, s(:expression, s(:CallExpression, s(:callee, s(:MemberExpression, s(:object, s(:Identifier, :console)), s(:property, s(:Identifier, :log)))), s(:arguments, s(:StringLiteral, :"hello JS!"))))), s(:ExpressionStatement, s(:expression, s(:CallExpression, s(:callee, s(:MemberExpression, s(:object, s(:Identifier, :console)), s(:property, s(:Identifier, :log)))), s(:arguments, s(:StringLiteral, :"hello JS!")))))]
+  end
 end