refactor specs

Author: ABaldwinHunter

spec/cc/engine/analyzers/violation_spec.rb

@@ -4,15 +4,11 @@
   describe "#calculate_points" do
     context "when issue mass exceeds threshold" do
       it "calculates mass overage points" do
-        base_points =  100
-        points_per = 5
-        threshold = 10
-
-        language = stub_language(base_points, points_per, threshold)
+        language = stub_language(base_points: 100, points_per: 5, mass_threshold: 10)
         issue = double(:issue, mass: 15)
         hashes = []
 
-        expected_points = base_points + points_per * (issue.mass - threshold)
+        expected_points = 100 + 5 * (issue.mass - 10)
 
         violation = CC::Engine::Analyzers::Violation.new(language, issue, hashes)
         points = violation.calculate_points
@@ -23,11 +19,7 @@
 
     context "when issue mass is less than threshold" do
       it "uses default" do
-        base_points = 100
-        points_per = 5
-        threshold = 18
-
-        language = stub_language(base_points, points_per, threshold)
+        language = stub_language(base_points: 100, points_per: 5, mass_threshold: 18)
         issue = double(:issue, mass: 15)
         hashes = []
 
@@ -42,15 +34,11 @@
 
     context "when issue mass equals threshold" do
       it "calculates remediation points" do
-        base_points = 100
-        points_per = 5
-        threshold = 15
-
-        language = stub_language(base_points, points_per, threshold)
-        issue = double(:issue, mass: 15)
+        language = stub_language(base_points: 100, points_per: 5, mass_threshold: 18)
+        issue = double(:issue, mass: language.mass_threshold)
         hashes = []
 
-        expected_points = base_points + points_per * (issue.mass - threshold)
+        expected_points = 100 + 5 * (issue.mass - language.mass_threshold)
 
         violation = CC::Engine::Analyzers::Violation.new(language, issue, hashes)
         points = violation.calculate_points
@@ -59,11 +47,11 @@
       end
     end
 
-    def stub_language(base_points, per_points, threshold)
+    def stub_language(args)
       double(:language,
-        base_points: base_points,
-        points_per: per_points,
-        mass_threshold: threshold
+        base_points: args[:base_points],
+        points_per: args[:points_per],
+        mass_threshold: args[:mass_threshold]
       )
     end
   end