This repository was archived by the owner on Jul 19, 2025. It is now read-only.
set rubocop settings to our standard style #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
force-pushed
the
will/rubocop-config
branch
from
42ad7eb to
6e252af
Compare
|
Should you just copy in the one from the style guide? |
@pbrisbin I did. Were you asking why I didn't, or suggesting that doing so was not appropriate? (Open to the latter argument, since there are some settings like allowed global vars there that aren't relevant to engines.) |
|
Oh, the diff was so small, and the PR description made it sound like a hand-edit, so I mistook it for a modification of a LGTM. |
|
@pbrisbin I think I had copied in the styleguide one a while ago, so this was just a sync of changes since then. Hence the small diff. |
wfleming
added a commit
that referenced
this pull request
Dec 18, 2015
set rubocop settings to our standard style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating these while convenient, and also since we haven't had PR integration turned for a while to check that's working.