Catch RubyParser exceptions #62
Conversation
Depending on what causes RubyParser to fail, the exception could be from Racc or from RubyParser, so we should catch these as well.
|
LGTM. Funny that CC failed with this |
|
Nice |
|
Um...yeah, I'm trying to think of how to explain the CC failure before I merge because it concerns me. CC was green on #60, which was the previous version of the duplication engine (b226). The later builds on #61 and #62 have been the newest duplication engine release (b258), and they've failed on parser errors. (On the same commit, even: compare this build and this build). Gem versions have not been changed in months, so they should be identical, and parser results shouldn't vary. And the changes in #60 aren't even involved with Ruby parsing at all (that happens in-line, unlike other languages that shell out to their respective parsers). So that's weird & I don't know how to explain it yet. |
|
Ugh. I've explained it: the prior duplication engine (b226) was still the very old one that just swallowed every exception ever. So of course it didn't fail. |
Depending on what causes RubyParser to fail, the exception could be from
Racc or from RubyParser, so we should catch these as well.
@codeclimate/review @ABaldwinHunter