From 52f3c2cf51a1d3f4b28a3d7b352434ab7f50379a Mon Sep 17 00:00:00 2001 From: Will Fleming Date: Tue, 29 Dec 2015 14:46:47 -0500 Subject: [PATCH] skip file message: format everything in one call I noticed that some logs reporting skip file messages seemed to interleave multiple messages: That's not terribly surprising due to concurrency. This changes the message formatting a bit & does it all in one method call to avoid the threading issues. --- lib/cc/engine/analyzers/analyzer_base.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/cc/engine/analyzers/analyzer_base.rb b/lib/cc/engine/analyzers/analyzer_base.rb index 8ccba8eb..4ea23cfd 100644 --- a/lib/cc/engine/analyzers/analyzer_base.rb +++ b/lib/cc/engine/analyzers/analyzer_base.rb @@ -18,8 +18,7 @@ def initialize(engine_config:) def run(file) process_file(file) rescue *RESCUABLE_ERRORS => ex - $stderr.puts("Skipping file #{file} due to exception:") - $stderr.puts("(#{ex.class}) #{ex.message} #{ex.backtrace.join("\n")}") + $stderr.puts("Skipping file #{file} due to exception (#{ex.class}): #{ex.message}\n#{ex.backtrace.join("\n")}") rescue => ex $stderr.puts("#{ex.class} error occurred processing file #{file}: aborting.") raise ex