From 6ea4ea3f0de302f48fe375e216816256843b3485 Mon Sep 17 00:00:00 2001 From: ABaldwinHunter Date: Mon, 14 Dec 2015 17:38:40 -0500 Subject: [PATCH 1/2] Only search for all caps This change reduces false positives found by the fixme engine, such as `fixme: enabled: true` in a .codeclimate.yml --- lib/fix-me.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fix-me.js b/lib/fix-me.js index 8b85231..cea3d96 100644 --- a/lib/fix-me.js +++ b/lib/fix-me.js @@ -35,7 +35,7 @@ FixMe.prototype.find = function(file){ self = this; // Prepare the grep string for execution (uses BusyBox grep) - var grepString = ["grep -inHwoE", fixmeStrings, '"' + file + '"'].join(" "); + var grepString = ["grep -nHwoE", fixmeStrings, '"' + file + '"'].join(" "); // Execute grep with the FIXME patterns From ee8d1cf27b2c9612cd8bc9aa17175dd7eb438167 Mon Sep 17 00:00:00 2001 From: ABaldwinHunter Date: Mon, 14 Dec 2015 17:40:22 -0500 Subject: [PATCH 2/2] Remove .codeclimate.yml from excludes There's no need to exclude this file now that only all caps trigger findings. --- .codeclimate.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index 96a5552..22eb9c9 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -11,4 +11,3 @@ exclude_paths: - "Dockerfile" - "bin/fixme" - "tests/**" -- ".codeclimate.yml"