Use weak shell quoting for npm tasks with -- (#116309)

alexr00 · web-flow · commit 5cf34afa107a · 2021-02-10T13:13:42.000+01:00
Fixes #115876
diff --git a/extensions/npm/src/tasks.ts b/extensions/npm/src/tasks.ts
@@ -324,7 +324,7 @@ export async function createTask(context: ExtensionContext, script: NpmTaskDefin
 		const result: (string | ShellQuotedString)[] = new Array(cmd.length);
 		for (let i = 0; i < cmd.length; i++) {
 			if (/\s/.test(cmd[i])) {
-				result[i] = { value: `${cmd[i]}`, quoting: ShellQuoting.Strong };
+				result[i] = { value: cmd[i], quoting: cmd[i].includes('--') ? ShellQuoting.Weak : ShellQuoting.Strong };
 			} else {
 				result[i] = cmd[i];
 			}

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ export async function createTask(context: ExtensionContext, script: NpmTaskDefin`
`324`	`324`	`const result: (string \| ShellQuotedString)[] = new Array(cmd.length);`
`325`	`325`	`for (let i = 0; i < cmd.length; i++) {`
`326`	`326`	`if (/\s/.test(cmd[i])) {`
`327`		- result[i] = { value: `${cmd[i]}`, quoting: ShellQuoting.Strong };
	`327`	`+ result[i] = { value: cmd[i], quoting: cmd[i].includes('--') ? ShellQuoting.Weak : ShellQuoting.Strong };`
`328`	`328`	`} else {`
`329`	`329`	`result[i] = cmd[i];`
`330`	`330`	`}`