Restore .yarnrc patch

Delete .yarnrc and update the build process where that file is read
since it no longer exists.

This should resolve the issues we keep having with mismatched Node
versions. This can be consistently replicated by spinning up a new
environment (no previous modules or cache), running yarn, then running
yarn watch.

Also use process.versions.node instead of process.version as the latter
has an extra v at the beginning.

Author: code-asher

lib/vscode/.yarnrc

@@ -42,6 +42,8 @@ BUILD_TARGETS.forEach(({ platform, arch }) => {
 });
 
 function getNodeVersion() {
+	// NOTE@coder: Fix version due to .yarnrc removal.
+	return process.versions.node;
 	const yarnrc = fs.readFileSync(path.join(REPO_ROOT, 'remote', '.yarnrc'), 'utf8');
 	const target = /^target "(.*)"$/m.exec(yarnrc)[1];
 	return target;

lib/vscode/build/gulpfile.reh.js

@@ -8,8 +8,8 @@ const path = require("path");
 const fs = require("fs");
 const root = path.dirname(path.dirname(__dirname));
 const yarnrcPath = path.join(root, 'remote', '.yarnrc');
-const yarnrc = fs.readFileSync(yarnrcPath, 'utf8');
-const version = /^target\s+"([^"]+)"$/m.exec(yarnrc)[1];
+// NOTE@coder: Fix version due to .yarnrc removal.
+const version = process.versions.node;
 const platform = process.platform;
 const arch = platform === 'darwin' ? 'x64' : process.arch;
 const node = platform === 'win32' ? 'node.exe' : 'node';

lib/vscode/build/lib/node.js

@@ -7,8 +7,8 @@ import * as path from 'path';
 
 const root = path.dirname(path.dirname(__dirname));
 
-// NOTE@coder: patch version detection
-const version = process.version;
+// NOTE@coder: Fix version due to .yarnrc removal.
+const version = process.versions.node;
 const platform = process.platform;
 const arch = platform === 'darwin' ? 'x64' : process.arch;
 

lib/vscode/build/lib/node.ts

@@ -269,6 +269,8 @@ function streamToPromise(stream) {
 }
 exports.streamToPromise = streamToPromise;
 function getElectronVersion() {
+    // NOTE@coder: Fix version due to .yarnrc removal.
+    return process.versions.node;
     const yarnrc = fs.readFileSync(path.join(root, '.yarnrc'), 'utf8');
     const target = /^target "(.*)"$/m.exec(yarnrc)[1];
     return target;

lib/vscode/build/lib/util.js

@@ -336,6 +336,6 @@ export function streamToPromise(stream: NodeJS.ReadWriteStream): Promise<void> {
 }
 
 export function getElectronVersion(): string {
-	// NOTE@coder: patch version detection
-	return process.version;
+	// NOTE@coder: Fix version due to .yarnrc removal.
+	return process.versions.node;
 }