fixup

Author: jsjoeio

test/unit/node/app.test.ts

@@ -10,8 +10,9 @@ import { getAvailablePort, tmpdir } from "../../utils/helpers"
 describe("createApp", () => {
   let spy: jest.SpyInstance
   let unlinkSpy: jest.SpyInstance
+  let port: number
 
-  beforeEach(() => {
+  beforeEach(async () => {
     spy = jest.spyOn(logger, "error")
     // NOTE:@jsjoeio
     // Be mindful when spying.
@@ -20,6 +21,7 @@ describe("createApp", () => {
     // then you can spy on those modules methods, like unlink.
     // See: https://github.com/aelbore/esbuild-jest/issues/26#issuecomment-893763840
     unlinkSpy = jest.spyOn(promises, "unlink")
+    port = await getAvailablePort()
   })
 
   afterEach(() => {
@@ -30,9 +32,7 @@ describe("createApp", () => {
     jest.restoreAllMocks()
   })
 
-  // TODO@jsjoeio refactor to use beforeEach and afterEach
   it("should return an Express app, a WebSockets Express app and an http server", async () => {
-    const port = await getAvailablePort()
     const defaultArgs = await setDefaults({
       port,
       _: [],
@@ -50,7 +50,6 @@ describe("createApp", () => {
   })
 
   it("should handle error events on the server", async () => {
-    const port = await getAvailablePort()
     const defaultArgs = await setDefaults({
       port,
       _: [],
@@ -82,11 +81,6 @@ describe("createApp", () => {
       _: [],
     })
 
-    // This looks funky, but that's because createApp
-    // returns an array like [app, wsApp, server]
-    // We only need server which is at index 2
-    // we do it this way so ESLint is happy that we're
-    // have no declared variables not being used
     async function masterBall() {
       const app = await createApp(defaultArgs)
       const server = app[2]
@@ -144,8 +138,6 @@ describe("createApp", () => {
   })
 
   it("should create an https server if args.cert exists", async () => {
-    // No idea why we have this weird optional string thing
-    const port = await getAvailablePort()
     const cert = new OptionalString("./test/utils/test.crt")
     const defaultArgs = await setDefaults({
       port,