Skip to content

Commit ed14c98

Browse files
committed
wip: add notes
1 parent c28207a commit ed14c98

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/browser/pages/vscode.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,19 @@ export function setBodyBackgroundToThemeBackgroundColor(document: Document, loca
112112
throw new Error(`${errorMsgPrefix} Could not set body background to theme background color. Could not find colorThemeData in localStorage.`)
113113
}
114114

115+
// TODO parse colorThemeData
116+
// which may need try/catch
117+
// or not since we are catching when we call the function
118+
// TODO get editor.background
119+
// TODO set it to style.background
120+
// also read about when to set background vs backgroundColor
121+
115122
return null
116123
}
117124

118125
try {
119126
document.body.style.background = JSON.parse(localStorage.getItem("colorThemeData")!).colorMap["editor.background"]
120127
} catch (error) {
121128
// Oh well.
129+
// TODO@jsjoeio add better logging here
122130
}

0 commit comments

Comments
 (0)