Documentation Improvement: Using s3file in development

[cvipul]

I am bit confused while reading the documentation about testing s3file in development.

On one hand it says

"The ClearableFileInput widget is only than automatically replaced when the DEFAULT_FILE_STORAGE setting is set to django-storages’ S3Boto3Storage"

and on the other it says

"S3File comes with a AWS S3 dummy backend. It behaves similar to the real S3 storage backend. It is automatically enabled, if the DEFAULT_FILE_STORAGE setting is set to FileSystemStorage."

So, if I want to use the dummy S3 backend, I cannot utilise the S3FileInputMixin.

If the documentation has steps to manually add S3FileInputMixin in development, that will be helpful.
Or will have to change the code in apps.py to look for some other variable in settings to determine if we are in development mode.

[codingjoe]

Hi @cvipul very good observation. This is absolute nonsense, and I am afraid, so is the implementation.
It should be as follows, simply set the storage backend to S3 on your production environment. Locally, you keep it at file system (aka. the default). Then everything should behave the same in both environments.

You'd you mind giving it a shot? I am on vacation right now, and it might take me a couple of days to create a patch.

[cvipul]

Understood. Let me make some changes and test it out.
Will raise a PR if everything works.

[codingjoe]

I opened a PR that should resolve the problem. I'd love if you'd review it. Especially the documentation change. Best, Joe

[cvipul]

Settings-wise the commit looks ok.
But I am facing another problem that's not allowing me to check the functioning end-to-end
I can see that s3file middleware is adding files to request.FILES, but when request object reaches the view, request.FILES is empty.

[codingjoe]

@cvipul interesting, would you mind sharing your MIDDLEWARE setting with me?

[cvipul]

Sorry, something was going wrong at my end.
When I tried to debug, it automatically fixed itself.

Can we release this new commit to pypi?

[codingjoe]

It's already released in version 5.0.6 😉