Skip to content

Upgraded to latest xeus (3.2.0) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2024

Conversation

anutosh491
Copy link
Collaborator

Fixes #94

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (46cfe09) to head (bba7317).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   59.83%   59.83%           
=======================================
  Files          15       15           
  Lines         600      600           
  Branches       59       59           
=======================================
  Hits          359      359           
  Misses        241      241           

@mcbarton
Copy link
Collaborator

@anutosh491 If this is the new minimum version, then probably worth changing the yml files for mamba development to check the ci hasn't picked up a version that's less than it.

@anutosh491
Copy link
Collaborator Author

Hi @mcbarton

So I don't think we are dependent on xeus. Rather xeus is pulled by xeus-zmq so we're good if we have an upper bound on xeus-zmq (< 2.0 ). But yeah for the emscripten build we can try that.

@anutosh491 anutosh491 requested a review from JohanMabille May 17, 2024 06:20
@anutosh491 anutosh491 force-pushed the upgrade_to_latest_xeus branch from 458892a to d974e2c Compare May 20, 2024 05:52
@anutosh491 anutosh491 force-pushed the upgrade_to_latest_xeus branch from e749620 to bba7317 Compare May 20, 2024 06:22
@vgvassilev vgvassilev merged commit 48a14c3 into compiler-research:main May 20, 2024
@anutosh491 anutosh491 deleted the upgrade_to_latest_xeus branch May 20, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest xeus 3.2
5 participants