refactor: sidebar-nav hasIcon()

xidedix · xidedix · commit a12128b01e3f · 2020-01-31T15:24:23.000+01:00
diff --git a/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav.service.ts b/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav.service.ts
@@ -40,8 +40,10 @@ export class SidebarNavHelper {
     const classes = {
       'nav-icon': true
     };
-    const icon = item.icon;
-    classes[icon] = this.hasIcon(item);
+    if (this.hasIcon(item)) {
+      const icon = item.icon;
+      classes[icon] = this.hasIcon(item);
+    }
     return classes;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,10 @@ export class SidebarNavHelper {`
`40`	`40`	`const classes = {`
`41`	`41`	`'nav-icon': true`
`42`	`42`	`};`
`43`		`- const icon = item.icon;`
`44`		`- classes[icon] = this.hasIcon(item);`
	`43`	`+ if (this.hasIcon(item)) {`
	`44`	`+ const icon = item.icon;`
	`45`	`+ classes[icon] = this.hasIcon(item);`
	`46`	`+ }`
`45`	`47`	`return classes;`
`46`	`48`	`}`
`47`	`49`	`}`